fix(package): preserve bundled MCP launcher permissions - #678
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kmbroai
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm packstrips the executable bit from the bundled POSIX MCP launcher because it is not an npmbinentry. This prevents the installed plugin from starting its MCP server on Linux and macOS.Closes #652.
Changes
publishConfig.executableFiles.Testing
pnpm pack --pack-destination <temporary-directory>tar -tvzf <packed-tarball> package/_bundled_plugin/scripts/launch_codex_security_mcp package/bin/codex-security.mjs(both launchers were0755)node scripts/check-package.mjs <packed-tarball>pnpm run typespnpm exec prettier --check package.json scripts/check-package.mjs scripts/smoke-package.mjsnpm package MCP launcher is not executable.Risk and rollout
The change affects npm archive metadata and package verification only. Windows continues to use the existing
.cmdlauncher. A new npm release is required for users to receive the corrected file mode.Public disclosure review
Change impact
The package now preserves the launcher's POSIX mode and proves the installed MCP server can start.
flowchart LR subgraph column_0["Package input"] direction TB node_0["Declare executable launcher<br/><code>publishConfig.executableFiles</code>"] end subgraph column_1["Packed artifact"] direction TB node_1["Tarball keeps execute mode<br/><code>npm package</code>"] end subgraph column_2["Package checks"] direction TB node_2["Check both launcher modes<br/><code>check-package.mjs</code>"] node_3["Start installed launcher<br/><code>smoke-package.mjs</code>"] end subgraph column_3["Outcome"] direction TB node_4["Block broken release archive<br/><code>node-release.yml</code>"] node_5["MCP initialization succeeds<br/><code>codex-security</code>"] end node_0 -->|"marks executable"| node_1 node_1 -->|"checks mode"| node_2 node_1 -->|"installs"| node_3 node_2 -->|"runs smoke"| node_3 node_2 -->|"gates"| node_4 node_3 -->|"initializes"| node_5 class node_0 changed class node_1 affected class node_2 changed class node_3 changed class node_4 affected class node_5 affected classDef changed fill:#d7f5e5,stroke:#237a4b,color:#111 classDef affected fill:#e6f0ff,stroke:#3569a8,color:#111 classDef context fill:#f2f3f5,stroke:#6e7781,color:#111Source evidence (6)
sdk/typescript/package.json:L38-L42— publishConfig declares the bundled POSIX launcher as an executable file.sdk/typescript/scripts/check-package.mjs:L229-L248— The archive listing is parsed and both launcher permission strings must contain execute bits.sdk/typescript/scripts/smoke-package.mjs:L355-L388— The smoke test installs the packed archive and verifies the complete bundled plugin tree.sdk/typescript/scripts/smoke-package.mjs:L206-L248— The installed launcher receives an initialize request and must return the codex-security server name.sdk/typescript/scripts/check-package.mjs:L312-L335— Full package inspection runs the installed-package smoke script after archive validation..github/workflows/node-release.yml:L150-L162— The release workflow packs the npm archive and runs check:package before publication continues.