Skip to content

refactor(plugin): generate the bundled runtime from canonical source - #675

Merged
soyeon-oai merged 19 commits into
mainfrom
codex/generated-bundled-plugin
Aug 27, 2026
Merged

soyeon-oai merged 19 commits into
mainfrom
codex/generated-bundled-plugin

Conversation

@soyeon-oai

Copy link
Copy Markdown
Collaborator

Summary

Make plugins/codex-security the canonical plugin source and generate the SDK's _bundled_plugin payload during CI and npm packaging.

Changes

  • Move authored plugin files into the canonical source tree and add the portable MCP implementation, plugin contract tests, deterministic triage evaluations, and patch-risk assessment sources.
  • Build the MCP server and assemble the runtime payload from an explicit file contract instead of tracking generated JavaScript or _bundled_plugin contents in Git.
  • Update SDK, container, release, and source-validation workflows to consume the generated plugin while keeping development-only inputs out of the npm artifact.
  • Reconcile finding evidence, scan recovery, completed checkpoints, and patch-risk contracts across the plugin, MCP server, and SDK.
  • Preserve executable permissions for the packaged MCP launcher and verify the installed package end to end.

Testing

  • Full SDK suite: 1,917 passed, 31 skipped. The remaining process-group test could not execute ps inside the local sandbox and passed when rerun outside it.
  • Focused patch-risk, CLI, credential, and runtime tests: 220 passed, 15 platform-specific skips.
  • Python plugin contract coverage: 197 passed, plus 96 passing subtests.
  • Passed pnpm run build:plugin, pnpm run build, pnpm run types, pnpm run format, MCP type checking, deterministic triage evaluations, and the checkpoint artifact regression test.
  • Packed and installed the npm artifact successfully; verified CLI startup, MCP initialization, credential locking, nested worker execution, all 118 bundled plugin files, and 0755 MCP launcher permissions.

Risk and rollout

  • Generated plugin files are no longer checked into Git; CI, release, and npm prepack now generate them from canonical source before use.
  • Existing consumers still receive the complete runtime payload in the npm package.
  • Source-only tests, evaluations, and MCP build inputs stay outside the published runtime payload.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-27T17:59:09.496757Z 0f8d1fa New commits
🔒 Security Review ✅ Completed 2026-08-27T06:21:32.527886Z 764ae41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 764ae417d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/tests-ts/plugin-root.ts
Comment thread plugins/codex-security/scripts/config_preflight.py Outdated
Comment thread plugins/codex-security/scripts/config_preflight.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 591b97345f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/scripts/check-plugin-source.mjs
Comment thread plugins/codex-security/scripts/workbench_db.py Outdated
Comment thread plugins/codex-security/scripts/finalize_scan_contract.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P2 Badge Decode Git text output as UTF-8

On hosts whose locale encoding is not UTF-8, notably Windows systems using legacy code pages, text=True now decodes Git's UTF-8 path output with the locale default. A repository such as C:\Users\José\repo can consequently be returned as a mojibake path by rev-parse --show-toplevel, causing subsequent canonical-target and snapshot operations to address a nonexistent directory and preventing the scan from starting. Preserve the explicit encoding="utf-8", errors="surrogateescape" behavior for text Git probes.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@soyeon-oai
soyeon-oai merged commit 42a60ff into main Aug 27, 2026
37 checks passed
@soyeon-oai
soyeon-oai deleted the codex/generated-bundled-plugin branch August 27, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants