refactor(plugin): generate the bundled runtime from canonical source - #675
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 764ae417d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 591b97345f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
On hosts whose locale encoding is not UTF-8, notably Windows systems using legacy code pages, text=True now decodes Git's UTF-8 path output with the locale default. A repository such as C:\Users\José\repo can consequently be returned as a mojibake path by rev-parse --show-toplevel, causing subsequent canonical-target and snapshot operations to address a nonexistent directory and preventing the scan from starting. Preserve the explicit encoding="utf-8", errors="surrogateescape" behavior for text Git probes.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Make
plugins/codex-securitythe canonical plugin source and generate the SDK's_bundled_pluginpayload during CI and npm packaging.Changes
_bundled_plugincontents in Git.Testing
psinside the local sandbox and passed when rerun outside it.pnpm run build:plugin,pnpm run build,pnpm run types,pnpm run format, MCP type checking, deterministic triage evaluations, and the checkpoint artifact regression test.0755MCP launcher permissions.Risk and rollout
prepacknow generate them from canonical source before use.Public disclosure review