Implement NamedMultiReservableCurrency and NamedBasicReservableCurrency in orml_currencies

[Chralt98]

Hey, this is related to #742.

It's the first try and it's not ready yet.

[xlc]

Ok. Simply add the trait bound makes no sense (that's what I read from the issue) but actually implement NamedMultiReservableCurrency is useful.

[Chralt98]

@xlc I don't get why the cargo fmt isn't correct. I formatted it multiple times.

[codecov-commenter]

Codecov Report

Merging #743 (8e4cd47) into master (39057da) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   77.68%   77.17%   -0.52%     
==========================================
  Files          92       92              
  Lines        9069     9129      +60     
==========================================
  Hits         7045     7045              
- Misses       2024     2084      +60     

Impacted Files	Coverage Δ
currencies/src/lib.rs	42.21% <0.00%> (-8.78%)	⬇️
traits/src/currency.rs	34.88% <0.00%> (-25.12%)	⬇️
traits/src/lib.rs	0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[Chralt98]

I let you finish the work. I think the most is done.

[Chralt98]

I don't really know if this might be a problem in the future. I mean we got a ReserveIdentifier for orml_tokens AND another ReserveIdentifier for pallet_balances.

PS: I hate this cargo fmt problem here in this repo...
Needed to use cargo +nightly fmt here.

[xlc]

Update your cargo to a recent version should resolve the fmt issue. This is one used by CI

open-runtime-module-library/.github/workflows/test.yml

Line 36 in 39057da

toolchain: nightly-2022-02-19

[xlc]

Multiple ReserveIdentifier is not an issue. You can require them to be the same one. Similar to how the Balance type for pallet-balances and orml-tokens are handled.

[Chralt98]

Thanks @xlc ! If there is anything to correct in my pull request, I am open to correct it after a review.

[zqhxuyuan]

LGTM except missing testcase, can you do this here or maybe in another PR? @Chralt98

[Chralt98]

@zqhxuyuan This depends on, what would be faster for a merge (Zeitgeist requires this functionality as fast as possible). I would propose, that it should get another pull request. But please verify the code before merge again :-D. I don't like to impact many chains to loose money. I would try to add test cases later in the day in another pull request. But I would be happy, if you could spend time on this too.

[zqhxuyuan]

LGTM

[zqhxuyuan]

It's better to add can_reserve method too, you can do this on later PR. @Chralt98

[Chralt98]

@zqhxuyuan You mean can_reserve_named for NamedBasicReservableCurrency and for NamedMultiReservableCurrency then? But this is not implemented for orml_tokens. Or what do you mean? And it's not part of the NamedReservableCurrency by substrate either.

[zqhxuyuan]

ok, my bad. the can_reseve is not needed for named implementation.