Repository navigation
Conversation
Pull request dashboard statusWaiting on maintainers · refreshed 2026-10-28 22:28 UTC Resolve merge conflicts, then merge when ready. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports consistent timeout handling across configuration and transports, with focused regression coverage and no unresolved blocking issues.
No open issues 🎉
What changed in this PR
This PR aligns declarative configuration with the schema’s “no limit” semantics for zero timeouts, preventing immediate export failures.
Changes:
- Convert zero timeouts to infinity for OTLP exporters and periodic metric readers.
- Translate infinite timeouts to
Noneat HTTP and gRPC transport boundaries. - Add regression coverage and a changelog entry.
| File | Description |
|---|---|
| opentelemetry-configuration/tests/test_tracer_provider.py | Test zero-timeout HTTP span exporter configuration. |
| opentelemetry-configuration/tests/test_meter_provider.py | Test zero-timeout metric exporters and periodic readers. |
| opentelemetry-configuration/tests/test_logger_provider.py | Test zero-timeout HTTP and gRPC log exporters. |
| opentelemetry-configuration/tests/test_common.py | Test shared timeout conversion. |
| opentelemetry-configuration/src/opentelemetry/configuration/_tracer_provider.py | Apply shared timeout conversion to span exporters. |
| opentelemetry-configuration/src/opentelemetry/configuration/_meter_provider.py | Handle unlimited exporter and periodic reader timeouts. |
| opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py | Apply shared timeout conversion to log exporters. |
| opentelemetry-configuration/src/opentelemetry/configuration/_common.py | Centralize timeout conversion and zero handling. |
| exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py | Verify infinite timeouts disable gRPC deadlines. |
| exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py | Translate infinite deadlines to None. |
| exporter/opentelemetry-exporter-otlp-common/tests/test_http_client.py | Verify unlimited HTTP timeouts across retry paths. |
| exporter/opentelemetry-exporter-otlp-common/src/opentelemetry/exporter/otlp/common/http.py | Normalize infinite timeouts before transport calls. |
| .changelog/5806.fixed | Document the zero-timeout fix. |
Review effort: Balanced
xrmx
approved these changes
Oct 26, 2026
|
|
||
|
|
||
| def _transport_timeout(timeout: float) -> float | None: | ||
| """Map an infinite timeout to ``None``, which transports treat as no timeout.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Map an infinite timeout to ``None``, which transports treat as no timeout.""" | |
| """Map an infinite timeout (as set by declarative configuration) to ``None``, which transports treat as no timeout.""" |
Contributor
Author
There was a problem hiding this comment.
This isn't quite true, a user can still theoretically pass in timeout=math.inf in the exporter constructors.
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
herin049
force-pushed
the
opentelemetry-python-decl-config-zero-timeout
branch
from
October 27, 2026 00:38
3086cfe to
90b4805
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the declarative configuration schema, a timeout of 0 on an OTLP exporter or a periodic metric reader means "no limit". Before this change, 0 was passed through literally, so every export got a zero second deadline and failed right away.
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck