Repository navigation
fix(sdk): detect character pattern wildcards in View instrument_name (#5664) - #5674
Merged
herin049 merged 6 commits intoSep 29, 2026
Conversation
…e when name is set (open-telemetry#5664)
Pull request dashboard statusMerged · refreshed 2026-09-29 22:27 UTC Status above doesn't look right?
|
lzchen
approved these changes
Sep 21, 2026
herin049
reviewed
Sep 25, 2026
herin049
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5664
According to the OpenTelemetry Metrics Specification, if
nameis provided,instrument_nameMUST NOT contain wildcard characters (*,?,[seq],[!seq]).Previously,
View.__init__only checked for*and?, missing[(and]). As a result, wildcard patterns likeinstrument_name="http_[0-9]"with a customnamepassed initialization without raising anExceptionand matched multiple instruments.This PR updates the wildcard check in
View.__init__to check for[as well, preventing character set wildcards when a custom View name is set.Type of Change
Checklist
.changelog/5664.fixed