[iblancasa]

Description

Fixes #4907

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Unit tests

Does This PR Require a Contrib Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added

[xrmx]

Haven't looked in detail at the PR but we are usually cautious on adding in development stuff to the api / sdk.

[trask]

hey @xrmx! check out open-telemetry/opentelemetry-specification#4886

if you can give this PR a basic review and "lgtm" without approving/merging it, then we can treat it as a "qualifying prototype" for marking it stable in the spec. we already have 3 qualifying prototypes which is the min bar for stabilizing the spec, but the more the better!

[MikeGoldsmith]

LGTM

[xrmx]

hey @xrmx! check out open-telemetry/opentelemetry-specification#4886

if you can give this PR a basic review and "lgtm" without approving/merging it, then we can treat it as a "qualifying prototype" for marking it stable in the spec. we already have 3 qualifying prototypes which is the min bar for stabilizing the spec, but the more the better!

Missed this comment but already approved the other PR 😅

[nagkumar91]

Nice implementation — spec compliance looks solid. A couple of nits below.

[MikeGoldsmith]

Looks like there are some merge conflicts that need fixing - otherwise I think this is ready for review / merge by a @open-telemetry/python-maintainers 👍🏻

[xrmx]

With something like this, tests should still pass:

diff --git a/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py b/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
index 6264b6eca..12a8cc08f 100644
--- a/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
+++ b/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
@@ -167,8 +167,6 @@ class Logger(ABC):
     def emit(
         self,
         record: LogRecord,
-        *,
-        exception: BaseException | None = None,
     ) -> None: ...
 
     @abstractmethod
@@ -214,8 +212,6 @@ class NoOpLogger(Logger):
     def emit(  # pylint:disable=arguments-differ
         self,
         record: LogRecord,
-        *,
-        exception: BaseException | None = None,
     ) -> None: ...
 
     def emit(
@@ -284,8 +280,6 @@ class ProxyLogger(Logger):
     def emit(  # pylint:disable=arguments-differ
         self,
         record: LogRecord,
-        *,
-        exception: BaseException | None = None,
     ) -> None: ...
 
     def emit(
@@ -303,7 +297,7 @@ class ProxyLogger(Logger):
         exception: BaseException | None = None,
     ) -> None:
         if record:
-            self._logger.emit(record, exception=exception)
+            self._logger.emit(record)
         else:
             self._logger.emit(
                 timestamp=timestamp,
diff --git a/opentelemetry-api/tests/logs/test_proxy.py b/opentelemetry-api/tests/logs/test_proxy.py
index f7744e5f3..1b5d0c22c 100644
--- a/opentelemetry-api/tests/logs/test_proxy.py
+++ b/opentelemetry-api/tests/logs/test_proxy.py
@@ -77,15 +77,12 @@ class TestProxy(LoggingGlobalsTest, unittest.TestCase):
         real_logger = provider.get_logger("proxy-test")
         self.assertIsInstance(real_logger, LoggerTest)
 
-    def test_proxy_logger_forwards_exception_with_record(self):
+    def test_proxy_logger_forwards_record_with_exception(self):
         logger = _logs_internal.ProxyLogger("proxy-test")
         logger._real_logger = Mock(spec=LoggerTest("proxy-test"))
-        record = _logs.LogRecord()
-        exception = ValueError("boom")
+        record = _logs.LogRecord(exception=ValueError("boom"))
 
         self.assertIsNotNone(logger._real_logger)
-        logger.emit(record, exception=exception)
+        logger.emit(record)
 
-        logger._real_logger.emit.assert_called_once_with(
-            record, exception=exception
-        )
+        logger._real_logger.emit.assert_called_once_with(record)
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
index 3633a308c..4ed043e67 100644
--- a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
+++ b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -793,19 +793,12 @@ class Logger(APILogger):
             return
         # If a record is provided, use it directly
         if record is not None:
-            record_exception = exception or getattr(record, "exception", None)
-            if record_exception is None and isinstance(
-                record, ReadWriteLogRecord
-            ):
-                record_exception = getattr(
-                    record.log_record, "exception", None
-                )
             if not isinstance(record, ReadWriteLogRecord):
-                if record_exception is not None:
+                if record.exception is not None:
                     record = _copy_log_record(
                         record,
                         _get_attributes_with_exception(
-                            record.attributes, record_exception
+                            record.attributes, record.exception
                         ),
                     )
                 # pylint:disable=protected-access
@@ -816,7 +809,7 @@ class Logger(APILogger):
                 )
             else:
                 record.log_record.attributes = _get_attributes_with_exception(
-                    record.log_record.attributes, record_exception
+                    record.log_record.attributes, record.log_record.exception
                 )
                 writable_record = record
         else: