Skip to content

Consider using __setitem__ / __getitem__ instead of explicit setters / getters for propagators #125

Closed

Description

@toumorokoshi

Based on this comment: #121 (comment)

We could probably just use convention to the setitem / getitem API and remove the need for the setter / getter functions as dictated by the propagators API.

Activity

  1. Oberon00 commented on Sep 13, 2019

    @Oberon00
    Member

    I'm for keeping explicit setters/getters as this is the most flexible API. But the user-facing API should accept mapping-like objects too.

  2. toumorokoshi commented on Jan 14, 2020

    @toumorokoshi
    MemberAuthor

    I'm going to close this issue as the context API is now changing dramatically with the new context propagation OTEP. Feedback around this should be sent to the OTEP: open-telemetry/oteps#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiAffects the API package.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions