Repository navigation
declarative config: gcp auth - #2020
Closed
zeitlinger wants to merge 44 commits into
Closed
zeitlinger wants to merge 44 commits into
zeitlinger wants to merge 44 commits into
Conversation
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
zeitlinger
commented
Jul 11, 2025
zeitlinger
marked this pull request as ready for review
July 14, 2025 16:17
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
changed the title
zeitlinger
commented
Jul 22, 2025
zeitlinger
left a comment
zeitlinger
left a comment
Member
Author
There was a problem hiding this comment.
notes from discussion with @jaydeluca
| * string_key: value | ||
| * </pre> | ||
| */ | ||
| final class DeclarativeConfigPropertiesBridge implements ConfigProperties { |
Member
Author
There was a problem hiding this comment.
the bridge is also part of open-telemetry/opentelemetry-java-instrumentation#14184 - once it's reviewed there it will be updated here
but that can also be done after this PR is merged
github-actions
Bot
requested review from
JonasKunz,
SylvainJuge,
jackshirazi,
jsuereth and
psx95
July 24, 2025 18:43
This reverts commit 2e2bb79.
…auth/GcpAuthAutoConfigurationCustomizerProvider.java Co-authored-by: Pranav Sharma <pranav.ps95@hotmail.com>
…auth/GcpAuthCustomizerProvider.java Co-authored-by: Pranav Sharma <pranav.ps95@hotmail.com>
zeitlinger
changed the title
Contributor
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by open-telemetry/opentelemetry-configuration#257 for GCP auth
Fixes #2012
todo: add reame like for #2031
Depends on open-telemetry/opentelemetry-java-instrumentation#14497