Conversation
RonFed
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125,
pellared and
ps-mir
as code owners
September 25, 2026 16:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9029 +/- ##
=====================================
Coverage 89.1% 89.1%
=====================================
Files 338 338
Lines 22274 22274
=====================================
+ Hits 19854 19856 +2
+ Misses 2420 2418 -2
🚀 New features to boost your workflow:
|
ps-mir
reviewed
Sep 28, 2026
ps-mir
left a comment
Member
There was a problem hiding this comment.
Change looks ok, suggestion for additional test and changelog entry.
RonFed
force-pushed
the
autosdk_ctx_fix
branch
2 times, most recently
from
September 29, 2026 07:14
56a43f7 to
87f77f8
Compare
RonFed
force-pushed
the
autosdk_ctx_fix
branch
from
September 29, 2026 07:16
87f77f8 to
40ce169
Compare
Contributor
Author
|
thanks @ps-mir, addressed your comments |
dmathieu
approved these changes
Sep 29, 2026
ps-mir
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-instrumentation
starthook can use the context hierarchy to track relationships between spans, the way the SDK does withSpanFromContext.autoTracer.Startcalls the hook beforeContextWithSpan, so the hook receives the parent's context rather than the new span's. When sibling spans started from the same context overlap in time, they then look like one span is the parent of the other.