Conversation
Add the Observability and Per-Series Start Timestamps sections to sdk/internal/x/README.md, which previously documented OTEL_GO_X_RESOURCE only. Add the missing README for exporters/otlp/otlptrace/otlptracehttp/internal/x, following the pattern of the equivalent README in otlptracegrpc. Fixes open-telemetry#9014
om7057
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
September 23, 2026 13:59
pellared
reviewed
Sep 24, 2026
Member
There was a problem hiding this comment.
I think that we miss a reference to this package documentation in exporters/otlp/otlptrace/otlptracehttp/doc.go
Contributor
Author
|
Added the missing reference to otlptracehttp/doc.go. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9017 +/- ##
=====================================
Coverage 89.1% 89.1%
=====================================
Files 338 338
Lines 22274 22274
=====================================
+ Hits 19854 19856 +2
+ Misses 2420 2418 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9014, part of #2046.
sdk/internal/x/README.md, which previously documentedOTEL_GO_X_RESOURCEonly.README.mdforexporters/otlp/otlptrace/otlptracehttp/internal/x, following the pattern of the equivalent README inotlptracegrpc.Test plan
make verify-readmes