[OpenTelemetry] Avoid enumerator allocations - #7681
Merged
martincostello merged 2 commits intoSep 1, 2026
Merged
martincostello merged 2 commits into
martincostello merged 2 commits into
Conversation
- Avoid allocating array when enumerating log scopes. - Avoid allocating enumerator when sampling attributes are a list.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7681 +/- ##
==========================================
+ Coverage 91.45% 91.48% +0.02%
==========================================
Files 318 318
Lines 17867 17881 +14
==========================================
+ Hits 16341 16358 +17
+ Misses 1526 1523 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes hot-path enumeration in tracing and logging to reduce allocations.
Changes:
- Indexes sampling attribute lists without allocating enumerators.
- Streams non-list log scopes instead of materializing arrays.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/OpenTelemetry/Trace/TracerProviderSdk.cs |
Adds list-aware sampling attribute iteration. |
src/OpenTelemetry/Logs/LogRecordScope.cs |
Delegates enumeration for non-list scopes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Apply the optimisation to both enumeration sites. - Extend test coverage.
martincostello
marked this pull request as ready for review
August 22, 2026 13:16
martincostello
enabled auto-merge
August 22, 2026 13:16
Pull request dashboard statusMerged · refreshed 2026-09-01 08:17 UTC Status above doesn't look right?
|
matt-hensley
approved these changes
Aug 22, 2026
This was referenced Aug 22, 2026
Kielek
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Found by investigating profile allocations in an application after upgrading to 1.18.0.
SamplingResultBenchmarks:
Scope Benchmarks
Scope Benchmarks
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)