feat(ui): Add select all for test case list in bundle suite#26125
feat(ui): Add select all for test case list in bundle suite#26125shah-harshit merged 7 commits intomainfrom
Conversation
…suite - Add showSelectAll prop to AddTestCaseList (default false); toggle: select all when not all selected, deselect all when all selected - Show selected count in Select All button when count > 0 (e.g. Select All (5)) - Apply list background #F8F9FC and Tailwind underline for Select All button - Use showSelectAll in BundleSuiteForm - Add unit tests for showSelectAll visibility and select/deselect behavior - Add label.select-all to all 19 locale files - Add E2E steps in TestSuite.spec for select all and deselect all in pipeline modal Made-with: Cursor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review 👍 Approved with suggestions 2 resolved / 3 findingsAdds a select all feature for test case lists in bundle suites with clean implementation. Consider clarifying the button label or behavior since "Select All" currently only applies to loaded items in the paginated view, not the full result set. 💡 Edge Case: "Select All" only applies to loaded items, not full result set📄 openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddTestCaseList/AddTestCaseList.component.tsx:298 📄 openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddTestCaseList/AddTestCaseList.component.tsx:137 The button label says "Select All" but the list uses infinite scroll with ✅ 2 resolved✅ Bug: Incorrect
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
|



Description
Adds optional Select All for the test case list used in the bundle suite flow. When enabled, users can select all visible test cases or deselect all with one click, and see the selected count in the button label.
Fixes collate issue #2249
Changes
AddTestCaseList
showSelectAllprop (defaultfalse): Whentrue, shows a "Select All" link. Click: select all when none/some are selected; deselect all when all are selected.Select All (N)whenN > 0selected (e.g.Select All (5)).#F8F9FC; Select All button uses Tailwindunderline.showSelectAlltoAddTestCaseListin the test case selection card.Unit tests (AddTestCaseList.component.test.tsx)
showSelectAllfalse (default): button not rendered.showSelectAlltrue with items: button visible; with no items: button not visible.onChangereceives all items; button shows count.onChange([]).Internationalization
label.select-alladded to all 19 locale files (en-us already had it) with appropriate translations (e.g. 全选, Tout sélectionner, Seleccionar todo, Alle auswählen).E2E (TestSuite.spec.ts)
(2).Testing
yarn test src/components/DataQuality/AddTestCaseList/AddTestCaseList.component.test.tsxTest Suites→ Logical TestSuite → Add test suite pipeline (select all / deselect all steps)Screenshots / UX
Screen.Recording.2026-02-26.at.5.19.15.PM.mov
Made with Cursor