Skip to content

chore: resolve open dependabot security alerts#1967

Closed
jonathannorris wants to merge 4 commits into
mainfrom
chore/dependabot-alerts-2
Closed

chore: resolve open dependabot security alerts#1967
jonathannorris wants to merge 4 commits into
mainfrom
chore/dependabot-alerts-2

Conversation

@jonathannorris

Copy link
Copy Markdown
Member

Summary

Resolved 2 of 7 open Dependabot security alerts. The remaining 5 alerts are for github.com/docker/docker and currently have no patched version available upstream.

Dependabot Alerts Resolved

Alert Package Severity Fix
#190 js-cookie high Added npm override to >=3.0.7 in playground-app/package.json (transitive via react-use)
#189 github.com/containerd/containerd/v2 high Bumped to v2.2.4 via go get + go mod tidy in test/integration/go.mod

Unresolvable Alerts

These Docker-related alerts in test/integration/go.mod (transitive via testcontainers-go) have no upstream patched version yet:

@netlify

netlify Bot commented May 25, 2026

Copy link
Copy Markdown

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 7bfda7e
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/6a1f189c1b56700008424139

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including an upgrade of js-cookie to version 3.0.7 in the playground app and minor version bumps for containerd and compress in the integration tests. A review comment suggests refining the js-cookie version override from a loose >=3.0.7 range to a safer ^3.0.7 caret range to avoid potential breaking changes from future major releases.

Comment thread playground-app/package.json Outdated
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris force-pushed the chore/dependabot-alerts-2 branch from d43ece7 to 75051b3 Compare June 1, 2026 14:16
@jonathannorris jonathannorris marked this pull request as ready for review June 1, 2026 15:59
@jonathannorris jonathannorris requested review from a team as code owners June 1, 2026 15:59
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 1, 2026
Comment on lines +20 to +22
"overrides": {
"js-cookie": "^3.0.7"
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this override be avoided? Is there a transitive dep we can update?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-use is the only dep pulling in js-cookie, and it's a production dependency. The latest version (17.6.0) still requires js-cookie: ^2.2.1, so there's nothing to bump. That said, I don't think we're actually affected: the vulnerability only triggers when a JSON-derived object is passed as the attributes argument to Cookies.set or similar, and the playground only imports useMedia and useObservable from react-use. No cookie APIs are used. I'd lean toward dismissing the alert.

@jonathannorris jonathannorris requested a review from toddbaert June 2, 2026 13:40
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves two Dependabot security alerts by updating vulnerable transitive dependencies in the integration test Go module and the playground app’s npm dependency graph, while documenting that remaining Docker/Moby advisories have no upstream fixes yet.

Changes:

  • Bump github.com/containerd/containerd/v2 to v2.2.4 in test/integration/go.mod (with corresponding go.sum updates).
  • Update Go transitive deps in the integration test module (klauspost/compress, hcsshim) as a result of the bump/tidy.
  • Add an npm overrides rule to force js-cookie to ^3.0.7 and update package-lock.json accordingly.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/integration/go.mod Bumps containerd/containerd/v2 (and klauspost/compress) to address security alerts in the integration test dependency graph.
test/integration/go.sum Syncs module checksums for the updated Go dependencies.
playground-app/package.json Adds an npm override to force js-cookie to a patched version.
playground-app/package-lock.json Locks js-cookie to 3.0.7 and records its metadata after applying the override.
Files not reviewed (1)
  • playground-app/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +20 to +22
"overrides": {
"js-cookie": "^3.0.7"
},
@jonathannorris

Copy link
Copy Markdown
Member Author

Superseded by #1980 (on the canonical chore/dependabot-alerts branch), which carries the same containerd + js-cookie fixes. Closing to keep a single active dependabot PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants