Skip to content

refactor: change the case of the flag manifest to camel case. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 12 commits into from
Oct 1, 2024
Merged

refactor: change the case of the flag manifest to camel case. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c67f767
feat!: initial commit for codegen CLI with golang support
anghelflorinm Sep 10, 2024
ec78985
docs!: add comments to few missing exported functions
anghelflorinm Sep 10, 2024
32f8069
refactor!: add better error messages for the CLI
anghelflorinm Sep 10, 2024
e4b02d0
refactor: move package to the top of the repository
anghelflorinm Sep 24, 2024
47889fc
refactor: move main file to top directory
anghelflorinm Sep 24, 2024
e5620ed
refactor: embed flag manifest schema into the script
anghelflorinm Sep 26, 2024
faf47d4
Merge branch 'main' into 2-cli-prototype
anghelflorinm Sep 26, 2024
9b8ddd8
fix: remove files after being moved
anghelflorinm Sep 26, 2024
5bdfc10
refactor: move main.go back into SRC and attach module to flagmanifes…
anghelflorinm Sep 30, 2024
896ac8d
Merge remote-tracking branch 'origin' into 2-cli-prototype
anghelflorinm Oct 1, 2024
a5059d0
refactor: change property names in manifest to camel case format
anghelflorinm Oct 1, 2024
01240cc
refactor: change property names to camel case
anghelflorinm Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions docs/schema/v0/flag_manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@
"$ref": "#/$defs/objectType"
}
],
"required": ["flag_type", "default_value"]
"required": ["flagType", "defaultValue"]
},
"booleanType": {
"type": "object",
"properties": {
"flag_type": {
"flagType": {
"type": "string",
"enum": ["boolean"]
},
"default_value": {
"defaultValue": {
"type": "boolean"
},
"description": {
Expand All @@ -57,11 +57,11 @@
"stringType": {
"type": "object",
"properties": {
"flag_type": {
"flagType": {
"type": "string",
"enum": ["string"]
},
"default_value": {
"defaultValue": {
"type": "string"
},
"description": {
Expand All @@ -73,11 +73,11 @@
"integerType": {
"type": "object",
"properties": {
"flag_type": {
"flagType": {
"type": "string",
"enum": ["integer"]
},
"default_value": {
"defaultValue": {
"type": "integer"
},
"description": {
Expand All @@ -89,11 +89,11 @@
"floatType": {
"type": "object",
"properties": {
"flag_type": {
"flagType": {
"type": "string",
"enum": ["float"]
},
"default_value": {
"defaultValue": {
"type": "number"
},
"description": {
Expand All @@ -105,11 +105,11 @@
"objectType": {
"type": "object",
"properties": {
"flag_type": {
"flagType": {
"type": "string",
"enum": ["object"]
},
"default_value": {
"defaultValue": {
"type": "object"
},
"description": {
Expand Down
9 changes: 0 additions & 9 deletions src/input.json
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ func unmarshalFlagManifest(data []byte, supportedFlagTypes map[generator.FlagTyp
}
for flagKey, iFlagData := range flags {
flagData := iFlagData.(map[string]interface{})
flagTypeString := flagData["flag_type"].(string)
flagTypeString := flagData["flagType"].(string)
flagType := stringToFlagType[flagTypeString]
if !supportedFlagTypes[flagType] {
log.Printf("Skipping generation of flag %q as type %v is not supported for this language", flagKey, flagTypeString)
continue
}
docs := flagData["description"].(string)
defaultValue := getDefaultValue(flagData["default_value"], flagType)
defaultValue := getDefaultValue(flagData["defaultValue"], flagType)
btData.Flags = append(btData.Flags, &generator.FlagTmplData{
Name: flagKey,
Type: flagType,
Expand Down