Skip to content

chore: update go generator with go-sdk v1.17.0 - #189

Merged
kriscoleman merged 10 commits into
open-feature:mainfrom
erka:rd/update-go-generator
Dec 3, 2025
Merged

chore: update go generator with go-sdk v1.17.0#189
kriscoleman merged 10 commits into
open-feature:mainfrom
erka:rd/update-go-generator

Conversation

@erka

@erka erka commented Nov 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR

  • update go generator with recent release of go sdk
  • introduce the output formatter for go generated code

Related Issues

Notes

  • This is a breaking change for those who use cli with go
    • new filename_gen.go
    • Value returns only value without an error
  • New go formatter may increase binary size.

@erka
erka force-pushed the rd/update-go-generator branch from cb863d6 to 7450a55 Compare November 27, 2025 19:56
@erka
erka marked this pull request as ready for review November 27, 2025 20:06
@erka
erka marked this pull request as draft November 27, 2025 20:48
@erka
chore: update go generator with go-sdk v1.17.0
b77f1ca 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
erka force-pushed the rd/update-go-generator branch from 7450a55 to b77f1ca Compare November 27, 2025 21:04
@erka
erka marked this pull request as ready for review November 27, 2025 21:07
sahidvelji
sahidvelji reviewed Nov 27, 2025
View reviewed changes
Comment thread internal/cmd/generate.go Outdated
Comment thread internal/cmd/testdata/success_go.golden Outdated
Comment thread internal/generators/golang/golang.go Outdated
Comment thread internal/generators/golang/golang.go Outdated
Comment thread internal/generators/golang/golang.tmpl Outdated
Comment thread internal/generators/golang/golang.tmpl
Comment thread internal/generators/golang/golang.tmpl Outdated
erka and others added 7 commits November 27, 2025 23:29
@erka @sahidvelji
Update internal/cmd/testdata/success_go.golden
e59e7d4 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka @sahidvelji
Update internal/generators/golang/golang.go
a41d618 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka @sahidvelji
Update internal/generators/golang/golang.go
3265bdb 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka @sahidvelji
Update internal/generators/golang/golang.tmpl
9f23035 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka @sahidvelji
Update internal/generators/golang/golang.tmpl
bf4d9f5 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka @sahidvelji
Update internal/cmd/generate.go
212970c 
Co-authored-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
update all the other things with new changes
5e93375 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
erka requested a review from sahidvelji November 28, 2025 00:02
@erka
small touches to generated godoc
fb9952f 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@sahidvelji

sahidvelji commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Lots of great changes here. Thank you! I suggest adjusting the PR title to reflect all the changes made. This might be more of a feat or refactor than a chore.

@erka

erka commented Nov 29, 2025

Copy link
Copy Markdown
Member Author

I suggest adjusting the PR title to reflect all the changes made. This might be more of a feat or refactor than a chore.

Naming things in conventional commits is always an adventure…
I didn’t add anything new to the CLI to call it a feat, didn’t change anything big enough to call it a refactor, and didn’t fix anything in the CLI to call it a fix. I just bumped one of the deps and adjusted the template. 😄

@kriscoleman

kriscoleman commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

I suggest adjusting the PR title to reflect all the changes made. This might be more of a feat or refactor than a chore.

Naming things in conventional commits is always an adventure… I didn’t add anything new to the CLI to call it a feat, didn’t change anything big enough to call it a refactor, and didn’t fix anything in the CLI to call it a fix. I just bumped one of the deps and adjusted the template. 😄

IMHO this would entail a chore, too.

kriscoleman
kriscoleman reviewed Dec 3, 2025
View reviewed changes
Comment thread internal/cmd/generate.go
kriscoleman
kriscoleman reviewed Dec 3, 2025
View reviewed changes
Comment thread test/go-integration/test.go Outdated
kriscoleman
kriscoleman reviewed Dec 3, 2025
View reviewed changes
Comment thread test/go-integration/openfeature/openfeature.go Outdated
@kriscoleman kriscoleman mentioned this pull request Dec 3, 2025
Closed
kriscoleman
kriscoleman requested changes Dec 3, 2025
View reviewed changes

@kriscoleman kriscoleman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this for us!

I left a comment about the integration tests, and would like to request we remove the assertions on implementation details. LMK what you think: #189 (comment)

@erka
address PR feedback
a43b500 
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
erka requested a review from kriscoleman December 3, 2025 12:25
kriscoleman
kriscoleman approved these changes Dec 3, 2025
View reviewed changes

@kriscoleman kriscoleman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great to me now, thanks for the integration test changes.
And again, thanks for the contribution and helping us maintain the latest SDK usage.

:shipit:

@kriscoleman
kriscoleman enabled auto-merge December 3, 2025 13:59
@kriscoleman
kriscoleman added this pull request to the merge queue Dec 3, 2025
Merged via the queue into open-feature:main with commit 6cb2453 Dec 3, 2025
6 checks passed
@openfeaturebot openfeaturebot mentioned this pull request Dec 3, 2025
Merged
@erka
erka deleted the rd/update-go-generator branch December 3, 2025 14:06
This was referenced Feb 6, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kriscoleman kriscoleman kriscoleman approved these changes
+1 more reviewer
@sahidvelji sahidvelji sahidvelji approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Go generator template: unexport types Go: generated file name Go generator template: comment should conform to convention

3 participants

@erka @sahidvelji @kriscoleman