feat: basic object flags by bbland1 · Pull Request #141 · open-feature/cli

bbland1 · 2025-06-14T18:08:01Z

This PR

all generators now support basic object flags
- object parsing for each language from go map[string]any to the language specific version added
- success_”lang”.golden files were updated to include object flags
current integration tests (go, nodes, csharp) updated to include the object flag
UnsupportedFlagType updated: still passed to each generator but empty to allow for object flags and keep the filtering logic originally established available for the possibility of any flag creation later on
make generate-docs was ran

Related Issues

Fixes #101

Notes

Follow-up Tasks

adding any validation & additional type safety
remove the UnsupportedFlagType as a passed parameter for creating new generator to encourage to usage of all the flags

How to test

Pull branch & build or go run to see new file made and manually confirm themeCustomization flag is there

go run ./cmd/openfeature generate go --manifest sample/sample_manifest.json

Run all unit tests

go test ./...

Run all integration tests

make test-integration

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

…p literal Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

This reverts commit dfddf88. Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

…alue Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

kriscoleman

thanks for the contribution @bbland1 , it's really great to see this feature go live.

I appreciate your engagement to tackle this and solve the nuances with c#!

beeme1mr

Wow, thanks! This is a great change. I left some minor feedback but it looks good to me.

From a Go perspective, would @sahidvelji and/or @erka you mind taking a look?
From a Python perspective, could @gruebel and/or @aepfli please take a look?

erka

great work!

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

gruebel

nice work 🍻 I added one comment, but this is more a heads up and doesn't need immediate attention.

gruebel · 2025-06-22T14:24:56Z

+        self,
+        evaluation_context: Optional[EvaluationContext] = None,
+        flag_evaluation_options: Optional[FlagEvaluationOptions] = None,
+    ) -> object:


with the next version (0.8.2) of the Python SDK this can be refined to

Suggested change

) -> object:

) -> typing.Union[Sequence[FlagValueType], typing.Mapping[str, FlagValueType]]:

bbland1 added 2 commits June 14, 2025 02:16

updating golang generator to include object flag

660eabd

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updating success_go to include object & having determing order for ma…

7334df8

…p literal Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 changed the title ~~Feat/basic object flags~~ feat: basic object flags Jun 14, 2025

bbland1 added 6 commits June 14, 2025 15:47

fixing type of ObjectValue & Details to actually be any as in client.go

f65221f

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixing spacing issue of template output

93c7950

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixing spacing issue of template return out

c6ba375

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

running generate docs per lefthook

2b2f1e2

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

adding object flag to react gen, updating templ and golden for new flag

e0e03f7

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updating python generator, tmpl and golden to include object

a70d327

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 commented Jun 15, 2025

View reviewed changes

Comment thread internal/generators/golang/golang.go

bbland1 added 7 commits June 15, 2025 02:52

added addtl func to handle nested values in object flags

8ef35dd

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updating nodejs generator and golden

196ca19

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed objectDetails for nodejs default to no be go map

a9b2efe

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

added object flag to nestjs go file and tmpl file

cb8e563

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed nestjs generator type and success golden

6fedc97

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updated go & python generators func name of helper

4ddace3

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

added object maping func to java gen remove filtering of obecjt flag out

3152146

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 commented Jun 17, 2025

View reviewed changes

Comment thread internal/generators/golang/golang.go Outdated

bbland1 added 8 commits June 17, 2025 00:38

fixed map logic to acutally have map for default value object

0de1167

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

renamed map helper func

68ee802

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updated java golden to include object

102c05c

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

added object to csharp flag and dictionary helper func

560d34e

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

added object parts to the tmpl

eef3460

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updated csharp golden to include object

1d40cd9

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed integration error about not using new Value

dfddf88

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

Revert "fixed integration error about not using new Value"

6591812

This reverts commit dfddf88. Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 force-pushed the feat/basic-object-flags branch from 562c269 to 6591812 Compare June 17, 2025 05:51

bbland1 added 3 commits June 17, 2025 01:55

fixed spacing on go and python map func

9e89319

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed to useoOpenfeature model value & structure builder

43157a9

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed structure builder call

0e76385

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 added 3 commits June 19, 2025 02:05

added object flag to integration files in test dir

6254b23

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

removed new for structure.builder because believe it is static

74ffe8e

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

fixed details method for theme to properly use the details call not v…

539b429

…alue Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

bbland1 marked this pull request as ready for review June 19, 2025 07:43

kriscoleman reviewed Jun 20, 2025

View reviewed changes

Comment thread internal/generators/csharp/csharp.go

kriscoleman approved these changes Jun 20, 2025

View reviewed changes

beeme1mr approved these changes Jun 20, 2025

View reviewed changes

Comment thread internal/cmd/testdata/success_nestjs.golden

Comment thread internal/cmd/testdata/success_nodejs.golden Outdated

Comment thread internal/generators/csharp/csharp.go

erka reviewed Jun 20, 2025

View reviewed changes

Comment thread internal/generators/golang/golang.go Outdated

erka approved these changes Jun 20, 2025

View reviewed changes

bbland1 added 2 commits June 20, 2025 12:26

fixed spacing of list builders in map conversion

74c229e

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

updated nodejs, nestjs, react to use JsonValue instead of object

89739b8

Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>

sahidvelji approved these changes Jun 21, 2025

View reviewed changes

gruebel approved these changes Jun 22, 2025

View reviewed changes

beeme1mr merged commit 288023c into open-feature:main Jun 22, 2025

openfeaturebot mentioned this pull request Jun 22, 2025

chore(main): release 0.3.6 #120

Merged

bbland1 deleted the feat/basic-object-flags branch June 24, 2025 22:06

This was referenced Feb 6, 2026

chore(main): release 0.4.0 #212

Closed

chore(main): release 0.4.0 #213

Closed

Navigation Menu

Uh oh!

feat: basic object flags - #141

feat: basic object flags#141
beeme1mr merged 31 commits into
open-feature:mainfrom
bbland1:feat/basic-object-flags

bbland1 commented Jun 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kriscoleman left a comment

Uh oh!

beeme1mr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erka left a comment

Uh oh!

Uh oh!

gruebel left a comment

Uh oh!

gruebel Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	) -> object:
	) -> typing.Union[Sequence[FlagValueType], typing.Mapping[str, FlagValueType]]:

Uh oh!

Conversation

bbland1 commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR

Related Issues

Notes

Follow-up Tasks

How to test

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kriscoleman left a comment

Choose a reason for hiding this comment

Uh oh!

beeme1mr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gruebel left a comment

Choose a reason for hiding this comment

Uh oh!

gruebel Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bbland1 commented Jun 14, 2025 •

edited

Loading