Merged
Conversation
Member
|
Suggestion for citing: file content for CITATIONS.cff Content for remaining docs can be adjusted to follow |
euronion
reviewed
Nov 12, 2025
Member
euronion
left a comment
There was a problem hiding this comment.
Looks good!
What I'm missing is a run down on how to use everything in combination for some simple data that should be processed and an example on how to use the pre-processed DEA data.
Comment on lines
+29
to
+32
| from technologydata.datapackage import DataPackage | ||
| from technologydata.technology_collection import TechnologyCollection | ||
| from technologydata.source_collection import SourceCollection | ||
|
|
Member
There was a problem hiding this comment.
Can't we directly import them everywhere like this to make it simpler and less intimidating?
Suggested change
| from technologydata.datapackage import DataPackage | |
| from technologydata.technology_collection import TechnologyCollection | |
| from technologydata.source_collection import SourceCollection | |
| from technologydata import DataPackage, TechnologyCollection, SourceCollection |
Member
Author
There was a problem hiding this comment.
Apologies but I do not understand. This is how the import should be done. I am not sure whether
from technologydata import DataPackage, TechnologyCollection, SourceCollection would actually work.
euronion
requested changes
Dec 11, 2025
Member
euronion
left a comment
There was a problem hiding this comment.
- Add content to landing page "Home"
- Update installation instructions after #80
- API reference doesn't seem to be included for me? Instead, the old API reference is still in each subpage -> preferably move this to a dedicated API section, like https://docs.pypsa.org/latest/api/networks/network/
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
This pull request addresses issues #65 and #43.
Changes proposed in this Pull Request
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.