This repository was archived by the owner on May 23, 2023. It is now read-only.
Don't set Content-Length property explicitly#6
Merged
Conversation
Previous code had a bug to set whole request contents instead of the length. In addition, HttpURLConnection.setRequestProperty() doesn't allow to set Content-Length because it is automatically set in the library.
oohira
added a commit
that referenced
this pull request
Jul 18, 2015
Don't set Content-Length property explicitly
Owner
Author
|
@maxkremer Thanks for your report. This is a terrible implementation. I fixed this bug and published v0.0.4 to Maven Central Repository. However, it is better for you to use the official Intercom v2 API library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @maxkremer pointed out, there was a potential bug to set whole request contents to Content-Length property instead of the length.
However, for good or bad, I found it does not have a impact for current users because HttpURLConnection.setRequestProperty() doesn't allow us to set Content-Length explicitly.
The wrong value (i.e. String.valueOf(body)) was just ignored. Of course, any other values are also ignored.