allow saving of buffer with ctrl+s - #1426
Merged
Merged
Conversation
|
|
glennsl
reviewed
Mar 6, 2020
Comment on lines
+845
to
+851
| let saveEffect = | ||
| Isolinear.Effect.create(~name="vim.save", () => { | ||
| let _ = Vim.input("<esc>"); | ||
| let _ = Vim.input("<esc>"); | ||
| let cursors = Vim.input("w"); | ||
| (); | ||
| }); |
Member
There was a problem hiding this comment.
w in normal mode will just move the cursor. What we want is to emulate :w followed by enter. Something like this should work I think:
Suggested change
| let saveEffect = | |
| Isolinear.Effect.create(~name="vim.save", () => { | |
| let _ = Vim.input("<esc>"); | |
| let _ = Vim.input("<esc>"); | |
| let cursors = Vim.input("w"); | |
| (); | |
| }); | |
| let saveEffect = | |
| Isolinear.Effect.create(~name="vim.save", () => { | |
| let _ = Vim.input("<esc>"); | |
| let _ = Vim.input("<esc>"); | |
| let _ = Vim.input(":"); | |
| let _ = Vim.input("w"); | |
| let _ = Vim.input("<CR>"); | |
| (); | |
| }); |
Contributor
Author
There was a problem hiding this comment.
@glennsl Good catch! I just updated the PR.
Member
|
Otherwise this seems on point! |
glennsl
reviewed
Mar 6, 2020
glennsl
left a comment
glennsl
left a comment
Member
There was a problem hiding this comment.
Works great! But see the comment below.
And could you also add this for macOS as <D-S>?
| { | ||
| key: "<C-S>", | ||
| command: "workbench.action.files.save", | ||
| condition: "insertMode" |> WhenExpr.parse, |
Member
There was a problem hiding this comment.
Do we not want this in any mode? i.e. editorTextFocus instead of insertMode.
Contributor
Author
|
@glennsl I added the mapping for macOS and switched the mode per your suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would something like this work for mapping ctrl+s to save? Thoughts on alternative ways to handle it?