Repository navigation
Don't crash when reporting an exception that has no message - #2137
Merged
mig5 merged 1 commit intoOct 28, 2026
Merged
Conversation
Some exceptions, such as stem.SocketClosed, are raised without arguments, so formatting the generic error with e.args[0] raised an IndexError inside the except block and the share got stuck. Fall back to the exception's class name instead. Fixes #2127
mig5
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2127.
OnionThread.run()(and the same pattern inTorConnectionThread.run()andAutoStartTimer.run()) formats unexpected errors withe.args[0]. Exceptions raised without arguments, like thestem.SocketClosed()in the Debian report, make that raiseIndexErrorinside theexceptblock, so the error signal is never emitted and the share stays stuck on "Starting...".The message now falls back to the exception's class name when it has no arguments.
Added
desktop/tests/test_threads.py, which runsOnionThread.run()with a mode whosestart_onion_serviceraisesstem.SocketClosed(). It fails with theIndexErrorbefore the change and passes after.