Repository navigation
fix(skills): contain evolution pane boundary scrolling - #517
Merged
Merged
Conversation
12 of 28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要 / Summary
修复进化页列表或详情滚到边界后继续带动外层页面的问题。隔离两栏的纵向滚动,并保留窄屏详情随整页滚动的行为。
Contain vertical scroll chaining at either evolution pane's boundary. Keep the stacked narrow-screen detail in normal page flow.
关联 Issue 或背景 / Related Issue or Context
Fixes #516.
涉及区域 / Affected Areas
PR 类型 / PR Type
最新代码确认 / Latest Codebase Confirmation
main分支开发,或在提交前已 rebase 或合并最新main。 / I developed from the latestmain, or rebased or merged the latestmainbefore submitting.同步命令 / Sync command:
git fetch origin maingit switch -c codex/fix-516-evolution-scroll-boundary origin/mainAI 编码披露 / AI Coding Disclosure
使用的 AI 模型 / AI model used:
GPT-6
使用的编码 Agent 工具 / Coding Agent tool used:
OpenAI Codex
仓库规范检查 / Repository Rules
@deepseek-ai/*NPM 契约。 / I did not modify DSH source or point tsconfig at a DSH source checkout, and used only published@deepseek-ai/*NPM contracts.src/host/protocol.ts为准,没有在两侧重复定义 wire DTO。 / The Client and Host boundary still uses browser-safesrc/host/protocol.tsas the source for wire DTOs.lib/文件。 / I did not commit tokens, credentials, private memory, unredacted logs, or generatedlib/files.兼容性与数据安全 / Compatibility and Data Safety
仅修改 Skills Source 样式中的两处声明。其他技能分页、横向滚动、模型调用、权限、配置和存储格式均保持原样;回滚可直接撤销样式变更。
Two CSS declarations in the Skills Source only. Other Skills tabs, horizontal scrolling, model calls, permissions, configuration and storage formats retain their behavior. Reverting the stylesheet change requires no data migration.
本地验证 / Local Validation
执行的命令 / Commands run:
结果摘要 / Result summary:
完整
pnpm run verify通过:文档、类型、确定性构建、全部插件测试、根测试(2257 passed | 7 skipped (2264))、真实 Headless 激活和包验证。Full
pnpm run verifypassed: docs, types, deterministic builds, all plugin suites, root tests (2257 passed | 7 skipped (2264)), real Headless activation and package validation. Conditional live-service tests remain skipped.真实浏览器回归:基线中列表到底后继续滚动使外层移动 88px;修复后保持 0px。左右两栏顶部/底部隔离通过;425px 窄屏列表边界隔离,详情仍能滚动整页且无横向溢出。使用已有夹具;未新增重复 CSS 声明的 JSDOM 测试。
Real browser regression: the baseline moved the outer page 88px after the list reached its boundary; the fix kept it at 0px. Both panes' top/bottom boundaries and the 425px stacked layout passed. Reused the existing fixture, without adding a JSDOM assertion that repeats a CSS declaration.
用户可见变更证据 / Local Feature Evidence
证据 / Evidence:
English record · 中文记录
DSH 0.2.1-rc.2 / Chromium / macOS, synthetic data, no model API calls. Windows Desktop UI was not manually exercised. 两种视口均在真实 WebUI 中验证,数据为合成数据,不调用模型;未手工验证 Windows Desktop UI。