[feat] Add Touch ID unlock for guest 1Password - #182
Open
Fail-Safe wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Adds opt-in Mac Touch ID unlock for 1Password running inside the Linux guest. A locked desktop app or connected browser extension requests system authentication, the focused VM shows a dedicated Mac Touch ID prompt, and the signed approval unlocks guest 1Password. Vaults and passkeys remain managed by guest 1Password; no host password manager or passkey forwarding is required.
Canceling or failing Touch ID opens a compact floating guest-password dialog using the standard polkit PAM session. The 1Password account-password option remains available. Setup reuses existing Touch ID enrollment and requires both an updated host helper and the explicit guest installer documented in
docs/onepassword-touch-id.md.Authorization and lifecycle
onepassword-unlockoperation bound to the exact 1Password unlock service and guest identity. Existing sudo requests retain their validation rules.PolkitAgent.Session. A successful dialog exit alone cannot authorize a request. Other 1Password actions use the PAM path.Validation
make teston the current upstream base, including signed request separation, replay/expiry checks, polkit caller validation, cancellation, fallback, and launcher cleanup coverage.The live app used an existing integrated local build. The PR is rebased onto current upstream
mainand tested separately. A fresh factory guest image and QEMU runtime rebuild are not part of this validation.