Skip reboot prompts in unattended updates - #8992
Open
maxcroy1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gum confirmwhen an update is unattended or has no usable input/output terminalEvidence
Before the fix, the isolated regression test passed its interactive control and then proved that
-ystill reached the prompt inside the pseudo-TTY created byscript(1):The failure reproduced four out of four times. The harness used a fake
HOME, forced a harmless kernel mismatch, and stubbeduname,pacman,gum,pgrep,omarchy-system-reboot,omarchy-state, and restart commands. No real prompt, package operation, state change, restart, or reboot was attempted.After the fix:
Testing
bash test/shell.d/update-restart-test.shin a Bubblewrap sandbox: passes./test/cliin the same sandbox: passes./test/allin the sandbox: the new test and existing update sequence coverage pass; the aggregate remains nonzero on five unrelated environment checks that require the separateomarchy-pkgscheckout, a live network route, or absence of an installed URL-check helperThe sandbox used a read-only checkout, private user/PID/network/IPC namespaces, temporary home/runtime filesystems, minimal devices, cleared desktop/session variables, and no access to the live Wayland, Hyprland, D-Bus, or user-service session.
Fixes #8986