Render media widget bar text with NativeRendering for consistency with other bar widgets - #11042
Open
Realrandombacon wants to merge 1 commit into
Open
Conversation
…h other bar widgets Other bar widgets (clock, network, audio, etc.) render their label through WidgetButton with renderType: Text.NativeRendering, while the media widget's play glyph and scrolling title use the default QtRendering. Same font family and size, but the different rasterizer is visible at bar sizes. Align the two bar-row Text elements on NativeRendering. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The media widget's bar text (play glyph + scrolling title) looks
slightly different from other bar widgets (clock, network, audio…)
even though they all use the same font family (
bar.fontFamily) andthe same size (
Style.font.body).Cause
Every widget routed through
WidgetButtonrenders its label withrenderType: Text.NativeRendering. The media widget's bar-rowTextelements use QML's default
Text.QtRendering, a differentrasterizer whose output is visibly different at small bar font sizes.
Fix
Add
renderType: Text.NativeRenderingto the two bar-rowTextelements (
glyphandlabelText) inshell/plugins/services/media/BarWidget.qml— 2 lines, no behaviorchange beyond the rasterizer.
🤖 Generated with Claude Code