Skip to content

bump colored, ctrlc#369

Merged
oli-obk merged 2 commits into
oli-obk:mainfrom
RalfJung:dep-bump
May 12, 2026
Merged

bump colored, ctrlc#369
oli-obk merged 2 commits into
oli-obk:mainfrom
RalfJung:dep-bump

Conversation

@RalfJung

@RalfJung RalfJung commented May 11, 2026

Copy link
Copy Markdown
Collaborator

This removes windows-targets from the lockfile.

Also cargo update all the integration tests.

@oli-obk

oli-obk commented May 11, 2026

Copy link
Copy Markdown
Owner

This crate is a library. I think that means users' code breaks if we use logic from deps that isn't required by Cargo.toml

@RalfJung

RalfJung commented May 11, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah I also realized that I didn't end up having to change the Cargo.toml here.

But it still seems worth getting windows-targets out of this repo, no?

@oli-obk

oli-obk commented May 12, 2026

Copy link
Copy Markdown
Owner

Yeah I also realized that I didn't end up having to change the Cargo.toml here.

uh. I meant the opposite. We need to change the Cargo.toml otherwise we're accidentally gonna cause some breakage in the future when relying on new colored APIs or sth

@RalfJung

Copy link
Copy Markdown
Collaborator Author

Ah. Yeah I guess ideally we'd have a CI job that tests with "minimal version" resolution but the Rust ecosystem is generally pretty bad at that (mostly because cargo has no stable support for it).

I bumped them in the toml file.

@oli-obk oli-obk enabled auto-merge May 12, 2026 06:52
@oli-obk oli-obk merged commit 6f63971 into oli-obk:main May 12, 2026
8 checks passed
@RalfJung RalfJung deleted the dep-bump branch May 12, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants