bump colored, ctrlc#369
Merged
Merged
Conversation
Owner
|
This crate is a library. I think that means users' code breaks if we use logic from deps that isn't required by Cargo.toml |
Collaborator
Author
|
Yeah I also realized that I didn't end up having to change the Cargo.toml here. But it still seems worth getting windows-targets out of this repo, no? |
Owner
uh. I meant the opposite. We need to change the |
Collaborator
Author
|
Ah. Yeah I guess ideally we'd have a CI job that tests with "minimal version" resolution but the Rust ecosystem is generally pretty bad at that (mostly because cargo has no stable support for it). I bumped them in the toml file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes windows-targets from the lockfile.
Also
cargo updateall the integration tests.