Skip to content

Add a matcher for windows path backslashes#102

Merged
oli-obk merged 1 commit into
oli-obk:mainfrom
Alexendoo:windows-paths
Jul 15, 2023
Merged

Add a matcher for windows path backslashes#102
oli-obk merged 1 commit into
oli-obk:mainfrom
Alexendoo:windows-paths

Conversation

@Alexendoo

Copy link
Copy Markdown
Contributor

Fixes #89

Slightly different than the rustc one, it assumes it will be ran against generally unsubstituted paths (no $DIR\foo\...) because Config::path_stderr_filter switches the \s in windows paths to /

It does require an extra feature enabled on regex for the unicode property escapes

@oli-obk

oli-obk commented Jul 15, 2023

Copy link
Copy Markdown
Owner

You need to run cargo test and commit the changed .stderr files

@oli-obk oli-obk merged commit ff66c4d into oli-obk:main Jul 15, 2023
@oli-obk

oli-obk commented Jul 15, 2023

Copy link
Copy Markdown
Owner

cool, I can probably start removing a bunch of weird ad-hoc filters in my tests now :D

@Alexendoo Alexendoo deleted the windows-paths branch July 15, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a backslash escaping heuristic to keep non-path backslashes around

2 participants