fix: Prevents useEffect double render in React18 StrictMode#266
Merged
Conversation
… v6-app to React18
…ck to loginCallback.test
jaredperreault-okta
approved these changes
Sep 5, 2023
|
The pipeline for publishing this appears to have failed: https://github.com/okta/okta-react/actions/runs/6088093926/job/16518033829 The currently available version on NPM is still 6.7.0. |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In React18 StrictMode, useEffects run twice on component mount. This causes
handleLoginRedirect()to run twice in theLoginCallbackcomponent, triggering anAuthSdkErrorfromauth-js.Issue Number: #263
Internal Ref: OKTA-635977
What is the new behavior?
Adds a top-level variable in
LoginCallbackthat preventshandleLoginRedirect()from running twice. Solution follows React18 guidanceDoes this PR introduce a breaking change?
Other information
jestto29.xto have access tojest.isolateModulesAsync()test-harness-appto React18 and adding a newstart:devscript (as well as a .env.development file) to enable testing on a development build since this bug only exists in React18 dev mode. Thev6-appwas also bumped to maintain parity