Samples - Catch 401 error on getUser()#164
Closed
denysoblohin-okta wants to merge 3 commits into
Closed
Conversation
added 3 commits
September 10, 2021 12:08
catch oktaAuth.getUser
This reverts commit 8f6c58d.
shuowu
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If access token is expired at time when user opens protected page which tries to load user info with
oktaAuth.getUser(), request will be rejected (witherr.xhr.status === 401). And user will seeUnhandled Rejection (AuthApiError).Issue Number:OKTA-421505
What is the new behavior?
Just catch rejection and write it to console.
TokenServicewill take care of renewing/removing tokens fromTokenManagerand updatingauthStatewhich will trigger effect in react component, re-runoktaAuth.getUser()and re-render with correct user infoDoes this PR introduce a breaking change?
Other information
Another option would be to call
oktaAuth.isAuthenticated()beforeoktaAuth.getUser(). For okta-auth-js 5.4.3 it would autorenew/remove expired tokens and return actualisAuthenticatedvalue. Also this approach would help to avoid unnecessarygetUser()call with expired token that would return 401Reviewers