Skip to content

fix(v0.14.2): remove unsupported tool from Claude review workflow - #176

Merged
ohgeeceee merged 2 commits into
mainfrom
copilot/fix-review-github-actions-job-again
Jul 29, 2026
Merged

fix(v0.14.2): remove unsupported tool from Claude review workflow#176
ohgeeceee merged 2 commits into
mainfrom
copilot/fix-review-github-actions-job-again

Conversation

Copilot AI commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this adds

Fixes the failing GitHub Actions review job by aligning the Claude review workflow with the supported PR-review tool allowlist. The job was aborting before review execution because the workflow exposed an extra gh pr review Bash tool not used by the documented review flow.

  • Root cause

    • anthropics/claude-code-action@v1 was failing at startup in the review job with an is_error:true result.
    • The workflow’s --allowedTools list included Bash(gh pr review:*), which was outside the known working review configuration.

  • Change

    • Removed the unsupported tool from .github/workflows/claude-review.yml.
    • Kept the existing review prompt and supported PR-comment/diff/view tools unchanged.

  • Result

    • The workflow now matches the documented Claude PR review pattern and should reach normal review execution instead of failing immediately.
claude_args: |
  --max-turns 20
  --allowedTools "Read,mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"

For data contributions (community/*.toml)

  • Vehicle: N/A
  • How verified: N/A
  • Loads cleanly (checked the Diagnostics tab — no warnings)
  • Original / community-derived knowledge, not from ISTA or other
    proprietary software

For code contributions

  • cargo fmt and cargo clippy are clean
  • Tested against the Simulator (and, if possible, a real car — say which)
  • No BMW proprietary data or trademarks added
  • Docs updated if any behavior claims changed

For release-cut PRs

  • Version bumped in Cargo.toml, package.json, and package-lock.json
  • Annotated tag created for this release (git tag -a vX.Y.Z)
  • Tag pushed so release.yml can build installers (git push origin vX.Y.Z)

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'review' fix(v0.14.2): remove unsupported tool from Claude review workflow Jul 29, 2026
Copilot AI requested a review from ohgeeceee July 29, 2026 02:26
@ohgeeceee
ohgeeceee marked this pull request as ready for review July 29, 2026 02:50
@ohgeeceee
ohgeeceee merged commit 94892f4 into main Jul 29, 2026
10 of 11 checks passed
@ohgeeceee ohgeeceee mentioned this pull request Jul 30, 2026
Merged
3 tasks
ohgeeceee added a commit that referenced this pull request Jul 30, 2026
@ohgeeceee
fix(ci): pin anthropics/claude-code-action to v1.0.183 (post Bun-tsco…
6dfa455 
…nfig-fix) (#189)

The review workflow's `claude-code-action@v1` (floating tag) has
been failing on every PR since at least 2026-07-29 with:

  Internal error: directory mismatch for directory
  "/home/runner/work/_actions/anthropics/claude-code-action/<ref>/tsconfig.json",
  fd 4. ... Claude result reported subtype success with is_error:true

Confirmed in the repo: 10 consecutive claude-review run failures
spanning the v0.14.2-slice3, v0.14.3-slice1/2/3, v0.14.3-doc-rot
and PRs #188 / #187 / #186 / #185 branches. The same SHA can succeed
on one run and fail on the next (per upstream issue
anthropics/claude-code-action#1266).

Upstream root cause: a Bun runtime bug that fires when the action
internally passes --tsconfig-override to bun. Fixed in
anthropics/claude-code-action#1315 (commit 232c9a15f4, 2026-06-09)
by dropping the --tsconfig-override flag from the three bun run
invocations in action.yml.

That fix IS in our current `@v1` resolution (verified SHA
be7b93b1907a4abad570368f3c74b6fe3807510b, dated 2026-07-25, latest
release v1.0.183). So the fix landed but the abort case still fires
on our ubuntu-24.04 runner — issue #1266 explicitly notes this is
environment-specific ("For some users this is a harmless stderr
warning; for others it aborts the action with exit code 1").

The smallest, most defensible change here: pin to the explicit
version that contains the upstream fix (v1.0.183, the latest at
this time) instead of the floating `@v1`. This makes the action
version reproducible, easy to bisect if it regresses, and easy to
bump when a confirmed-good release lands.

Past fix attempts in this repo:
- PR #173 (empty — abandoned)
- PR #174 (empty — abandoned)
- PR #176 (removed `Bash(gh pr review:*)` from --allowedTools —
  didn't fix the underlying issue, the bug has continued firing
  since)

Files changed (3):
- .github/workflows/claude-review.yml — the one that fires on every
  PR and is the visible failure PR #188 / PR #187 / etc all hit
- .github/workflows/claude.yml — Claude Code Action itself
- .github/workflows/claude-implement-issue.yml — Claude Code
  Implement Issue workflow

Tier A (CI workflows per CLAUDE.md). PR auto-merge eligible.

If the review check still fails after this lands, the next move
(documented for a follow-up PR, not in scope here) is either:
- Pin to a SHA explicitly confirmed working on ubuntu-24.04 runners
  (issue #1266 has a "known-good SHA" ask that wasn't answered)
- Swap to a different action family (e.g. claude-code-base-action
  has fewer internal bun invocations and doesn't trip the same bug)
- Disable the workflow trigger and rely on local agent dispatch,
  the workaround issue #1266's reporter ended up using

Verification:
- [x] Workflow YAML lints clean (CI lint step on the patch output)
- [x] v1.0.183 is the latest release at this time per
  https://github.com/anthropics/claude-code-action/releases
  (verified 2026-07-30)
- [x] Same SHA (`be7b93b1`) is what `@v1` resolves to currently,
  so this pin is functionally equivalent to the floating tag for
  today — but is now explicit and reproducible

Co-authored-by: ohgeeceee <ohgeeceee@users.noreply.github.com>
@ohgeeceee ohgeeceee mentioned this pull request Jul 30, 2026
Merged
5 tasks
github-actions Bot pushed a commit that referenced this pull request Jul 30, 2026
@ohgeeceee
docs(changelog): backfill v0.14.1 + v0.14.2 entries (#192)
d7dc9ae 
Closes the CHANGELOG gap that PR #188 (v0.14.3 slice 4) flagged
in the "Notes on the version surface" section. v0.14.1 and
v0.14.2 shipped without CHANGELOG entries because each cycle's
slice-closeout PR either forgot the version-surface sync step
or deferred it as a separate housekeeping follow-up.

This PR does the backfill from PR commit history:

- ## [0.14.1] — 2026-07-27
  - Tauri 2 `window.confirm()` auto-dismiss fix (PR #169, Tier B)
  - Simulator regenerate-on-identify (PR #169, Tier B)
  - Per-ECU freeze-schema split (PR #170, Tier A)
  Note: PR #169 shipped two slices in one PR (the dialog.js
  helper + the sim regenerate-on-identify). PR #170 is grouped
  under v0.14.1 because the ROADMAP treats the freeze-schema
  split as part of the v0.14.1 housekeeping arc (it was
  originally targeted at v0.14.0 but its tests-only refactor
  landed late and folded into the v0.14.1 PR #171 cycle-table
  retroactive close).

- ## [0.14.2] — 2026-07-29
  - Cycle plan + ROADMAP v0.14.2 header (PR #171, Tier A)
  - `community/profiles/n62.toml` enrichment — `0x5C` oil temp
    (PR #175, Tier A)
  - Live Data panel UX polish — poll-rate, peaks, range bar,
    snapshot-CSV, NRC error surface (PR #177, Tier A)
  - `docs/validation/n62-real-car.md` harness doc (PR #178,
    Tier A)
  - Claude review workflow repair — remove unsupported
    `Bash(gh pr review:*)` tool from `--allowedTools` (PR #176,
    Tier B)
  Note: the original v0.14.3 "Notes on the version surface"
  paragraph omitted PR #176 from the v0.14.2 PR list — fixed in
  this backfill.

Also updates the v0.14.3 "Notes on the version surface" section
to point at this backfill PR instead of flagging it as a
backlog item, and includes PR #176 in the v0.14.2 PR list.

Tier A — docs only. No code changes, no transport/** changes,
no protocol/** changes. PR auto-merge eligible per CLAUDE.md
once CI is green.

Verification:
- [x] CHANGELOG section order preserved: [0.14.0] (line 8) →
      [0.14.1] (line 71) → [0.14.2] (line 105) → [0.14.3]
      (line 168) → [0.13.0] (line 273) — chronological order
      matches merge order (verified via `gh pr list --state
      merged --json number,title,mergedAt`)
- [x] Every PR number cited in a backfill entry exists and
      was actually merged to main (verified via `gh pr view
      N --json mergedAt` for PRs #169, #170, #171, #175, #176,
      #177, #178)
- [x] All slice claims verified against each PR's actual body
      — no fabricated content per the data-over-invention rule
- [x] `node --test src/js/*.test.js` — 163/163 pass (no code
      changes; 5 slice 3b tests absent because this branch is
      from origin/main pre-PR-190)
- [x] `pytest backend/tests/` — 166/166 pass

Cross-references:
- PR #188 — v0.14.3 slice 4 (the cycle-closeout PR that
  flagged this backfill as the appropriate scope)
- CLAUDE.md golden rule #5 — version-surface sync (the rule
  this PR enforces retroactively for v0.14.1 + v0.14.2)
- docs/v0.14.3_plan.md — the cycle plan that calls out the
  forward-roadmap maintenance pattern this PR continues

Co-authored-by: ohgeeceee <ohgeeceee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ohgeeceee ohgeeceee ohgeeceee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Copilot code review Copilot

@ohgeeceee ohgeeceee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ohgeeceee