feat(v0.10.0): clickable NEEDS VERIFICATION badge + fix repo URL - #130
Conversation
v0.10.0 follow-up to the plan verification badge (#127). - The NEEDS VERIFICATION badge now opens the real-car validation harness doc (docs/validation/testplans.md) on click — the procedure to upgrade a plan. VERIFIED shows a static green tag. Uses the app's existing external-link pattern (window.open target=_blank noopener). - Fixes a latent TDZ bug from #127: loadTestPlan previously read plan.verified before the plan was resolved (ReferenceError at runtime; unit tests never exercised loadTestPlan). The badge now renders after get_test_plan resolves, via a new renderPlanVerifiedBadge() helper. - plan_verified_state() now carries the harness href + tooltip. - Fixed the about modal's stale repo owner (ohjoncurrie -> ohgeeceee, the canonical owner confirmed via git remote + gh repo view + gh pr view). Tier A. Verified: npm run build compiles clean; node --check main.js OK; node --test 56 pass.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deeb1a3527
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| label: "NEEDS VERIFICATION", | ||
| cls: "is-unverified", | ||
| href: "https://github.com/ohgeeceee/beeemuu/blob/main/docs/validation/testplans.md", |
There was a problem hiding this comment.
The clickable badge targets ohgeeceee/beeemuu, but the repository is ohgeeceee/beemuu as documented in README.md and src-tauri/Cargo.toml, so every click opens a nonexistent repository instead of the validation guide. The source text added at src/index.html:499 contains the same extra e and should be corrected as well.
Useful? React with 👍 / 👎.
| if (verifiedEl) { | ||
| renderPlanVerifiedBadge(verifiedEl, plan ? plan.verified : undefined); | ||
| } |
There was a problem hiding this comment.
When a user opens a second DTC after viewing a plan with a verification marker, the old badge remains beside the newly assigned code until this await resolves. If get_test_plan rejects, the catch path never updates the badge, so the second DTC remains permanently mislabeled and retains the previous badge's click handler; hide or reset it when beginning the lookup or on failure.
Useful? React with 👍 / 👎.
| el.title = v.title; | ||
| el.style.cursor = "pointer"; | ||
| el.onclick = () => window.open(v.href, "_blank", "noopener"); |
There was a problem hiding this comment.
For plans needing verification, the new navigation is attached only through onclick to a non-focusable <span>, so keyboard-only users cannot focus or activate the validation link. Render this state as an anchor or button (or supply equivalent focus, role, and keyboard handling) so the advertised click target is available without a pointer.
Useful? React with 👍 / 👎.
…der claim (#182) Two small doc-rot fixes from the same audit that found the v0.15.1/v0.16.0/v0.16.3/v0.16.5 false claims in the forward roadmap (PR #181): 1. community/testplans/README.md:33 — 'UI rendering lands in a follow-up' was wrong. The walkthrough verification badge is shipped in the desktop app (src/js/main.js renderPlanVerifiedBadge, PR #127) and in the standalone walkthrough HTML bundle (src/js/walkthrough_bundle.js buildBundleHtml, PR #127/#130). The README now points at both rendering sites. 2. community/freeze/README.md:68 — the reference to 'docs/validation/freeze-frame.md harness (planned v0.14.1)' was stale: the doc didn't exist. v0.14.1 shipped without it. This PR ships the missing harness doc + updates the README reference. The new docs/validation/freeze-frame.md mirrors the n62-real-car.md (PR #178) and can-broadcast.md (PR #164) shape: 5 steps, copy-pasteable GitHub issue template, a 'Verification results' closeout, and explicit cross-references. The per-ECU schema format (offset, width, scale, bias) is already documented in community/freeze/README.md and referenced verbatim. The DME/DSC/FRM freeze-frame byte-0..2 convention (engine speed u16 BE + coolant byte - 40) is the only portion that's shared across all three simulator fixtures and chassis-validated today; offsets 3-8 remain unverified and the harness doc is explicit about the 'do-not-invent-meaning' discipline. Tier A, no test impact, no code changes. Auto-merge on CI green per CLAUDE.md rule 2. Co-authored-by: ohgeeceee <ohgeeceee@users.noreply.github.com>
1 participant
Summary
v0.10.0 follow-up to the plan verification badge (#127).
docs/validation/testplans.md) on click — the procedure to upgrade a plan from needs-verification to verified. A VERIFIED plan shows a static green tag. Uses the app's existing external-link convention (window.open(target=_blank, noopener)), same as the oracle/opinion source links.loadTestPlanreadplan.verifiedbeforeconst plan = await invoke(...)was declared — aReferenceErrorat runtime. Unit tests never exercisedloadTestPlan, so it slipped through. The badge now renders after the plan resolves, via a newrenderPlanVerifiedBadge()helper.plan_verified_state()now carries the harnesshref+ tooltip.ohjoncurrie/beeemuu; the canonical owner (confirmed via git remote,gh repo view, andgh pr view 127) isohgeeceee/beeemuu. Corrected.Verification
npm run build(canonicaltauri build) — passes, producesBeeEmUu_0.10.0_x64bundles.node --check src/js/main.js— OK.node --test src/js/test/*.test.cjs— 56 passing.docs/validation/testplans.mdconfirmed present atorigin/main(localgit show).Note on link target: GitHub's contents API + HTML blob pages 404 from this sandbox's egress (same 404 for the known-good
service-functions.md), but the file is authoritatively present at the repo tip via local git, and the ownerohgeeceee/beeemuuis verified by three independent sources. The/blob/main/...URL is the standard GitHub path and resolves in a normal browser.Tier
A (frontend-only; no protected path). 2 files changed:
src/js/main.js,src/index.html.Files