Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
RolloutRecorder::load_rollout_itemscurrently parses every JSONL record and retains every decodedRolloutItemin oneVec. A single oversized rollout can therefore makethread/reador resume consume many times the file size in app-server memory.This change puts the guard at the legacy thread-store full-history boundary. Files over 100 MiB now return a clear
InvalidRequestbefore ordinary JSONL parsing starts. The source rollout is left byte-for-byte untouched, and metadata-only listing/read paths continue to work.The 100 MiB threshold is intentionally conservative: issue openai#29510 includes a report where a 106 MB rollout was already enough to stall a 16 GB machine.
This addresses the unbounded full-history hydration path reported in openai#29510. It does not attempt automatic truncation, quarantine, or migration; those would need separate product decisions.
Validation
cargo +1.95.0 fmt --all -- --checkgit diff --checkTargeted Rust execution is left to CI because compiling the workspace locally exceeded the constrained test host's safe disk budget; the PR is draft until those checks pass.
Fork CI note: a manual
rust-cidispatch was attempted, but GitHub rejected the jobs before allocating a runner because Actions are locked for the fork owner's account. No test or build step ran, so that infrastructure failure is not a code result.