[vdbergh]

Logic:

1. Check if cutechess-cli exists and is working.

2. If not: download it.

3. Check if downloaded cutechess-cli is working.

4. If not: try to restore a backup copy.

5. If successful check if the backup copy is working.

6. If not: bail out.

Also: do not treat MacOS specially in the updater.

Also: only setup/verify during worker startup.

Solves #1368 .

[vdbergh]

@ppigazzini I wonder if you could have a look at this PR? I think it is a nice refactoring of the setup of cutechess-cli. Perhaps it might also deal correctly with this issue (if it is solvable at all):

https://tests.stockfishchess.org/actions?action=&user=technologov&before=1657958686.643&count=100

[vdbergh]

Last push just moves a comment. No functional change.

[ppigazzini]

Tested working on WLS and MSYS2 with all the combinations of:

• echo > testing/cutechess-cli
• echo > _testing_1658323691.928943/cutechess-cli
• zipball = "cutechess-cli-macos-64bit.zip"

If I'm not wrong the error messages are now only worker side.

[vdbergh]

If I'm not wrong the error messages are now only worker side.

Yes that is true.

But IMHO checking that cutechess is working is part of the start up of the worker (like selecting a compiler).

[ppigazzini]

I meant that I don't view entries in Events log about cutechess-cli problems:
https://dfts-0.pigazzini.it/actions

I agree that worker.py is the right module for the cutechess-cli check.

This the output worker side:

Obtaining version info for /home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli ...
Unable to run cutechess-cli. Error: [Errno 8] Exec format error: '/home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli'
Downloading cutechess-cli-macos-64bit.zip ...
Obtaining version info for /home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli ...
Unable to run cutechess-cli. Error: [Errno 8] Exec format error: '/home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli'
The downloaded cutechess-cli is not working. Trying to restore a backup copy ...
Obtaining version info for /home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli ...
Unable to run cutechess-cli. Error: [Errno 8] Exec format error: '/home/usr00/_git/__test_folder00/fishtest/worker/testing/cutechess-cli'
The backup copy /home/usr00/_git/__test_folder00/fishtest/worker/_testing_1658324023.636352/cutechess-cli doesn't work either ...
No suitable cutechess-cli found
Deleting lock file /home/usr00/_git/__test_folder00/fishtest/worker/worker.lock

[vdbergh]

The messages in the event log come from failed tasks. In this PR the check for a working cutechess-cli is done before a task is started. So there are no messages in the event log.

My plan is to create a log api to post messages to the event log not associated with a task.

[ppigazzini]

A collateral problem found during the tests of this PR.
The worker update is checked/done in fetch_and_handle_task(), we have now some code than can prevent a fixing update.

If we add at example the support for ARM (eg the link to the cutechess-cli-arm.zip), an already installed worker will exit (because a not working cutechess) before checking the version.

[vdbergh]

I agree! So the update test should also be done a startup….

[vdbergh]

Latest push does an update test before checking cutechess.

[ppigazzini]

Nice improvement, thank you @vdbergh :)
Triggered the workers update.

PS: please try to update black. Mine is latest v 22.6.0 and writes 2**30, yours still writes 2 ** 30, see
psf/black#2726

PS2: I installed several python tools with pipx, for me is a simple pipx upgrade-all