Skip to content

Add zizmor to pre-commit and fix findings#174

Open
hugovk wants to merge 3 commits into
ofek:masterfrom
hugovk:zizmor
Open

Add zizmor to pre-commit and fix findings#174
hugovk wants to merge 3 commits into
ofek:masterfrom
hugovk:zizmor

Conversation

@hugovk

@hugovk hugovk commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

We're not using Trusted Publishers yet:

  info[use-trusted-publishing]: prefer trusted publishing for authentication
    --> .github/workflows/deploy.yml:42:9
     |
  42 |         uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # v1.14.0
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this step
  ...
  45 |           password: ${{ secrets.PYPI_API_TOKEN }}
     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ uses a manually-configured credential instead of Trusted Publishing
     |
     = note: audit confidence → High

This is only an informational finding, so I've ignored it for now. We should switch over at some point, which requires some minimal config for the project on PyPI.

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0720138) to head (3cc9c4d).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          547       558   +11     
  Branches        74        43   -31     
=========================================
+ Hits           547       558   +11     
Flag Coverage Δ
macOS-latest 100.00% <ø> (ø)
ubuntu-latest 100.00% <ø> (ø)
windows-latest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant