[ADD] estate: add estate module for tutoriel - #1370
Conversation
…ir views. Try onchange, compute and inverse
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for the incredible work. As an initial review, I left some comments in the PR, and some general ones below.
Don't forget to add an empty line at the end of each file. We mostly do this for a clean history, since if somebody adds a line at the end of the file, they'll technically be changing your line as well, messing up the git blame or history of that specific line.
For the order of attributes in the model, the naming of the xml ids, and other guidelines, you can follow the coding guidelines.
One minor comment, why do you put the string of your views "Channel", "Test", etc.?
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for the great work. I have one general comment. For the commit titles, the [ADD] tag should be used when adding a new module, but otherwise, for most of the other commits (except for the estate_account one), they are improvements to the estate module, so they should have the [IMP] tag. Also, don't forget to add the empty line to every file, not just the python files.
There was a problem hiding this comment.
nitpick(feel free to ignore it for now): we usually do the imports as from . import <model>
| def _compute_date_deadline(self): | ||
| for record in self: | ||
| record.date_deadline = fields.Datetime.add( | ||
| record.create_date.date() or fields.Datetime.now().date(), |
There was a problem hiding this comment.
what if the create_date is false? this would cause an error. Also, there is a fields.Date.today(), so we don't need to do the fields.Datetime.now().date() imo

No description provided.