Skip to content

[ADD] Real estate: Initial setup for module - #1369

Open
sdemeesterde wants to merge 19 commits into
odoo:19.0from
odoo-dev:19.0-realestate-samde
Open

[ADD] Real estate: Initial setup for module#1369
sdemeesterde wants to merge 19 commits into
odoo:19.0from
odoo-dev:19.0-realestate-samde

Conversation

@sdemeesterde

Copy link
Copy Markdown

Hello,

Happy to make my first PR in odoo.

@sdemeesterde
sdemeesterde requested a review from SaddemAmine July 20, 2026 13:36
@robodoo

robodoo commented Jul 20, 2026

Copy link
Copy Markdown

Pull request status dashboard

@sdemeesterde
sdemeesterde requested a review from YassinWalid July 22, 2026 07:19

@YassinWalid YassinWalid left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the impressive work. I have done an initial review, and left some comments in the PR and other general ones below. Please check them out, especially the coding guidelines and how to format the name/id of python fields and methods, xml record names and ids, as well as the model names themselves

Instead of date and datetime, you should use fields.Date and fields.Datetime

For the naming convention of records' name/id, name of models, fields, the order of methods for a model, and much more, check the coding guidelines for useful tips/rules.

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/security/ir.model.access.csv
Comment thread estate/views/estate_menus.xml Outdated
Comment thread estate/views/estate_property_offers_list.xml Outdated
Comment thread estate/views/estate_property_tag_views.xml Outdated
Comment thread estate/views/estate_property_views.xml Outdated
@sdemeesterde
sdemeesterde force-pushed the 19.0-realestate-samde branch from 5142161 to 15fcd01 Compare July 30, 2026 11:07
@sdemeesterde

Copy link
Copy Markdown
Author

Thank you for the many comments ! I really appreciate all the feedback, and tried to fix all the issues.

I still have a warning from the ci about the translation, but should I care about it ?

@sdemeesterde
sdemeesterde requested a review from YassinWalid July 30, 2026 11:14
@sdemeesterde sdemeesterde self-assigned this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants