[ADD] Real estate: Initial setup for module - #1369
Conversation
YassinWalid
left a comment
There was a problem hiding this comment.
Thanks for the impressive work. I have done an initial review, and left some comments in the PR and other general ones below. Please check them out, especially the coding guidelines and how to format the name/id of python fields and methods, xml record names and ids, as well as the model names themselves
Instead of date and datetime, you should use fields.Date and fields.Datetime
For the naming convention of records' name/id, name of models, fields, the order of methods for a model, and much more, check the coding guidelines for useful tips/rules.
5142161 to
15fcd01
Compare
|
Thank you for the many comments ! I really appreciate all the feedback, and tried to fix all the issues. I still have a warning from the ci about the translation, but should I care about it ? |

Hello,
Happy to make my first PR in odoo.