PR Onboarding toher - #1367
Conversation
|
|
Tom-Hermann
changed the title
Tom-Hermann
changed the title
715ac2a to
f4ece5c
Compare
SaddemAmine
left a comment
SaddemAmine
left a comment
There was a problem hiding this comment.
Thank you for the PR Tom!
I invite you to read the git guidelines to understand more how to structure your commit messages, since you're currently violating how it is usually done.
Reading the coding guidelines is also a very good idea, I noticed you have lots of typos and naming issues throughout, focusing on them will help you integrate better in teams with big codebases where your diffs will need to be consistent with the rest.
| 'name': 'Estate', | ||
| 'depends': ['base'], | ||
| 'application': True, | ||
| 'author': 'toher', |
There was a problem hiding this comment.
Keep in mind that this is usually Odoo, since we work here.
| self.env["account.move"].with_context(default_move_type='out_invoice').create({ | ||
| "partner_id": property.buyer_id.id, | ||
| "move_type": "out_invoice", |
There was a problem hiding this comment.
I guess you don't need the context since you specify the move_type in the dict
| 'data': [ | ||
| ], |
There was a problem hiding this comment.
I wonder if you can just remove this
cd780be to
34b4daf
Compare
3 participants
[ADD] Chap-2