Skip to content

fix(photos): the ingest regenerates semantics.json, the one derivation it skipped #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oddharsh merged 2 commits into from
Aug 29, 2026
Merged

fix(photos): the ingest regenerates semantics.json, the one derivation it skipped #662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f73d40
fix(photos): the ingest regenerates semantics.json, the one derivatio…
oddharsh Aug 29, 2026
d8ecf5c
Merge branch 'main' into fix/photos-semantics-ingest
oddharsh Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions tools/photos/add-photos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,11 @@
# it ships at deploy like every other committed artifact. (It replaced the
# manifest:images KV cache over a runtime R2 list(); there is no cache to
# bust anymore.)
# 6. captions anything still missing alt text (gen-alt-text.py), then validates
# the whole artifact graph — pixels, EXIF, histograms, captions, the index —
# via check-photo-pipeline.ts, which fails the run rather than let an
# 6. captions anything still missing alt text (gen-alt-text.py), rebuilds the
# retrieval terms queryPhotos ranks on (gen-photo-semantics.ts, which reads
# those captions and so must follow them), then validates the whole artifact
# graph — pixels, EXIF, histograms, captions, the index — via
# check-photo-pipeline.ts, which fails the run rather than let an
# unlabelled image reach a deploy
#
# REMOTE_RENDER_ONLY=1 skips R2 uploads. The GitHub Actions pipeline uses it
Expand Down Expand Up @@ -623,6 +625,27 @@ else
echo " python3 missing — skipping alt-text generation"
fi

# retrieval terms for every stem, and the ONE stem-keyed artifact this script has
# never regenerated. The other five reach it: hashes and fingerprints through
# hash-thumbnails.sh, histograms through extract-photo-metadata.sh plus the zenc
# bake, alt text through the block above. #609's `covers` verdict found
# semantics.json at 158 of 165 and repaired the generator, which had been joining
# a deleted www/ for a week (gotcha 40). That fixed the producer and left the hole
# that let seven photos drift out of it, so the next add would open it again.
#
# It runs AFTER gen-alt-text.py because the derived tier folds alt[stem] into
# `terms`. Captioning second leaves a new stem carrying camera vocabulary and no
# subject, which is the quiet half of this failure: the photo stays findable one
# tier down and nothing errors.
#
# No credential and no network. It reads metadata.json, hashes.json and alt.json,
# so unlike the captioner it cannot be rate-limited, and `set -e` makes a failure
# stop the run rather than degrade it. Re-running over the whole library is a
# byte-identical no-op, measured on all 165 stems at 95ms. --vision is the opt-in
# model tier and is deliberately not passed here, since it wants a token and this
# path has to work without one.
node "$PROJECT_DIR/tools/photos/gen-photo-semantics.ts"

node "$PROJECT_DIR/tools/photos/check-photo-pipeline.ts"
echo ""

Expand Down
Loading