Repository navigation
chore(og): recapture the /lens card after #205's toolbar - #1038
Merged
Merged
Conversation
The /lens card was last captured in #173 (2026-07-30), and #841 only re-encoded it from PNG to JPEG. So it still showed the pre-#205 toolbar: the Compare mode tab first, and the machine lenses in a strip above all three panes. Production has the mode row as Human, Machine, Browser, Delta, Compare, with the lens tabs inside the Machine View pane. Recaptured from production with the MAINTENANCE.md recipe: both Browser-Rendering caches prewarmed, then OG_ONLY=lens bun run og-cards. The first recapture stamped an empty white box where the favicon goes. #346 moved /lens's icon to a root-relative /section-icons/lens.svg, and the card is built with setContent, so the href resolves against nothing. gen-og-cards.ts now inlines a root-relative .svg icon from public/, the same bytes the page serves. data: icons pass through untouched, and no other carded page declares a root-relative icon.
Contributor
Wire-size diff vs merge base
Brotli q11, the quality the edge serves. Every number here is deterministic: Client assetsNo change. 31 files, 109.72 KiB Brotli total. PagesNo change. 70 files, 631.98 KiB Brotli total. Worker bundleNo change. 262.11 KiB gzip. Dictionary transportFamily dictionary acquisition: no change, 14.41 KiB q11.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
aadhar-sh | cf23b3d | Commit Preview URL Branch Preview URL |
Sep 30 2026, 12:32 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /lens unfurl card still showed the toolbar from before #205. It was last captured in #173 (2026-07-30); #841 only re-encoded it from PNG to JPEG through zenc.
Before: the Compare mode tab sits first in the mode row, and the machine lenses (Agent-ready?, Raw response, What it claims, ...) run in one strip above all three panes. Verdict reads 13/100.
After: matches production today. The mode row reads Human, Machine, Browser, Delta, Compare. The lens tabs live inside the Machine View pane (Raw response, Reader's guess, What it costs, ...). The Browser Run pane shows the After interaction recipes and the HTTP vs rendered delta. Verdict reads 90/100.
How
The MAINTENANCE.md recipe: prewarm
/lens/shotand/lens/browserfor stripe.com (both were cold, 10s and 15s), thenOG_ONLY=lens bun run og-cards. Onlypublic/og/lens.jpgwas rewritten. 154,194 B to 146,463 B.One generator fix
The first recapture stamped an empty white box where the favicon goes. #346 moved /lens to a root-relative
/section-icons/lens.svg, and the card is built withsetContent, so there's no base URL to resolve it against. That's the failure the generator's own comment records for the section-icon fallback.gen-og-cards.tsnow inlines a root-relative.svgicon frompublic/, the same bytes the page serves.data:icons pass through untouched, so no other card changes: the 3 other pages declaring a root-relative icon are section indexes the generator doesn't card.Checks
bun run derive:check: 5 fresh, 0 stale.og/cardsis declared unverifiable (it captures production), so there's no lock to move.bun run lint,bun run typecheck: clean.bun run test: 985 pass, 0 fail.The
preset: "#lx-browser-run"inWORKER_PAGESnames a button that no longer exists; itscount()guard skips it, and Browser Run auto-renders anyway. Left as is.