feat: Paginate compareCommits and compareCommitsWithBasehead - #678
Merged
wolfy1339 merged 7 commits intoJun 16, 2025
Merged
Conversation
Contributor
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
1 task done
wolfy1339
reviewed
May 16, 2025
Julesssss
force-pushed
the
feat-paginate-compare-commits
branch
from
June 16, 2025 20:42
ed95c8b to
dd5f0b7
Compare
wolfy1339
reviewed
Jun 16, 2025
Julesssss
force-pushed
the
feat-paginate-compare-commits
branch
from
June 16, 2025 21:50
28a1858 to
1d9822d
Compare
wolfy1339
marked this pull request as ready for review
June 16, 2025 22:06
wolfy1339
approved these changes
Jun 16, 2025
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in 🧰 Octokit Active
Contributor
|
🎉 This PR is included in version 13.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 16, 2025
Contributor
Author
|
Thanks @Julesssss for finishing and @wolfy1339 for reviewing 🙇🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #647
Before the change?
compareCommitsandcompareCommitsWithBaseheadare not correctly paginated.After the change?
compareCommitsandcompareCommitsWithBaseheadare paginatedPull request checklist
Does this introduce a breaking change?
No breaking changes (unless someone is using paginate with
compareCommits, which doesn't work).Please see our docs on breaking changes to help!