Skip to content

feat: add param to runHook to capture errors - #617

Merged
peternhale merged 2 commits into
mainfrom
mdonnalley/hooks-errors
Feb 10, 2023
Merged

peternhale merged 2 commits into
mainfrom
mdonnalley/hooks-errors

Conversation

@mdonnalley

Copy link
Copy Markdown
Contributor

Adds new captureErrors parameter to Config.runHook. If it's true, errors from hooks will be captured and returned to the caller; if it's false or undefined, all errors will be thrown

Fixes #515
Fixes oclif/oclif#1083

@W-12514447@

@peternhale
peternhale merged commit 7e7ca96 into main Feb 10, 2023
@peternhale
peternhale deleted the mdonnalley/hooks-errors branch February 10, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calling this.exit() from a hook does nothing - regression in oclif 2+ Hooks are not working properly

2 participants