Repository navigation
feat: add generic for extending Hooks on config.runHook - #1359
Merged
Merged
Conversation
Contributor
Author
|
Apologies for the tag @mdonnalley — mind taking a look at this? |
Contributor
|
hey @kanadgupta, sorry for the late reply! |
cristiand391
approved these changes
Apr 24, 2025
Contributor
|
PR looks good but and got tests running by pushing a parallel branch but there's something with latest node v23 that broke our current unit tests (pretty sure it's unrelated to your changes). thanks for contributing! |
cristiand391
added a commit
that referenced
this pull request
Apr 28, 2025
kanadgupta
added a commit
to readmeio/rdme
that referenced
this pull request
Apr 28, 2025
oclif/core#1359 has been merged
3 tasks done
kanadgupta
added a commit
to readmeio/rdme
that referenced
this pull request
Apr 28, 2025
## 🧰 Changes - [x] bumps our openapi definition to the latest version - [x] updates our types to incorporate oclif/core#1359 - [x] also bumps a few deps, see below... **before** ``` Package Current Wanted Latest Location Depended by @oclif/plugin-autocomplete 3.2.26 3.2.27 3.2.27 node_modules/@oclif/plugin-autocomplete rdme @types/validator 13.12.3 13.15.0 13.15.0 node_modules/@types/validator rdme @vitest/coverage-v8 3.1.1 3.1.2 3.1.2 node_modules/@vitest/coverage-v8 rdme @vitest/expect 3.1.1 3.1.2 3.1.2 node_modules/@vitest/expect rdme eslint 8.57.1 8.57.1 9.25.1 node_modules/eslint rdme ignore 7.0.3 7.0.4 7.0.4 node_modules/ignore rdme knip 5.46.4 5.50.5 5.50.5 node_modules/knip rdme nock 14.0.2 14.0.4 14.0.4 node_modules/nock rdme rollup 4.38.0 4.40.1 4.40.1 node_modules/rollup rdme type-fest 4.39.0 4.40.1 4.40.1 node_modules/type-fest rdme typescript 5.8.2 5.8.3 5.8.3 node_modules/typescript rdme undici 5.29.0 5.29.0 7.8.0 node_modules/undici rdme vitest 3.1.1 3.1.2 3.1.2 node_modules/vitest rdme ``` **after** ``` Package Current Wanted Latest Location Depended by eslint 8.57.1 8.57.1 9.25.1 node_modules/eslint rdme undici 5.29.0 5.29.0 7.8.0 node_modules/undici rdme ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Hookinterface has a handy generic so we can have additional type safety around hook inputs/outputs:core/src/interfaces/hooks.ts
Line 76 in e60d769
This PR extends that logic over to the
config.runHookmethod.