Repository navigation
feat: improved types and exports - #1076
Merged
Merged
Conversation
mdonnalley
marked this pull request as draft
May 7, 2024 19:19
mshanemc
reviewed
May 15, 2024
| ], | ||
| "license": "MIT", | ||
| "main": "./lib/index.js", | ||
| "exports": { |
Member
There was a problem hiding this comment.
this includes all the ones I came here to check 😄
mshanemc
reviewed
May 15, 2024
|
|
||
| export class CLIError extends Error implements OclifError { | ||
| code?: string | ||
| code?: string | undefined |
Member
There was a problem hiding this comment.
what's the value of having both ? and the | undefined ?
mshanemc
reviewed
May 15, 2024
| public bin!: string | ||
| public binAliases?: string[] | ||
| public binPath?: string | ||
| public binAliases?: string[] | undefined |
Member
There was a problem hiding this comment.
should any of these be readonly? conversely, do we want people mutating them all?
Contributor
Author
There was a problem hiding this comment.
Can't be readonly because all these props are assigned in the .load method. Typescript doesn't like that
mdonnalley
marked this pull request as ready for review
May 15, 2024 21:06
cristiand391
approved these changes
May 17, 2024
mdonnalley
added a commit
that referenced
this pull request
Jun 4, 2024
* chore: bump major version * feat: slimmer ux (#1056) * chore: bump major version * feat: slimmer ux module * test: no fancy-tests * chore(release): 4.0.0-v4.0 [skip ci] * chore: code review * chore(release): 4.0.0-v4.1 [skip ci] * chore(release): 4.0.0-beta.1 [skip ci] * chore: remove duplicate dep * test: windows unit tests * test: windows unit tests --------- Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com> * chore(release): 4.0.0-beta.2 [skip ci] * feat: add customizable logger * feat: remove native error logger * fix: cache child loggers * chore(release): 4.0.0-beta.3 [skip ci] * chore(release): 4.0.0-beta.4 [skip ci] * feat: support rc files (#1067) * feat: support rc files * chore: code review * chore(release): 4.0.0-beta.5 [skip ci] * chore(release): 4.0.0-beta.6 [skip ci] * fix: revert ignoreDuplicates in warn * chore(release): 4.0.0-beta.7 [skip ci] * feat: improved types and top-level exports (#1076) * feat: improved PJSON type * feat: enable exactOptionalPropertyTypes * feat: theme can be object or file path * feat: support target and identifier for helpClass * chore: add jsdocs to Configuration type * fix: add back scope to pjson type * feat: top level exports * fix: simplify ux export * chore: cleanup * feat: export logger too * chore(release): 4.0.0-beta.8 [skip ci] * feat: remove baseFlags * test: use oclif/test v4 and improve test coverage * fix: clarify types * test: use default sinon sandbox * test: use new major of oclif/test * test: add interop test for core v3 * test: skip spinner test on windows * chore: code review * chore(release): 4.0.0-beta.9 [skip ci] * fix: restore baseFlags support (#1085) * chore(release): 4.0.0-beta.10 [skip ci] * fix: improve types and ProdOnlyCache * chore(release): 4.0.0-beta.11 [skip ci] * fix: update hook type * chore(release): 4.0.0-beta.12 [skip ci] * fix: allow empty ux.stdout * chore(release): 4.0.0-beta.13 [skip ci] * chore: add ux README * fix: check supports-color in colorize * chore(release): 4.0.0-beta.14 [skip ci] * feat: support tsx for runtime transpilation * chore(release): 4.0.0-beta.15 [skip ci] * chore(release): 4.0.0-beta.16 [skip ci] --------- Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com> Co-authored-by: Steve Hetzel <shetzel@salesforce.com> Co-authored-by: Willie Ruemmele <willieruemmele@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interfaces.PJSONexactOptionalPropertyTypes(Fixes Build failure withexactOptionalPropertyTypesenabled #960)target/identifierlogic to custom help classesdefaultproperty from configuration@W-15470589@
@W-15470627@