Skip to content

feat: improved types and exports - #1076

Merged
cristiand391 merged 12 commits into
prerelease/betafrom
mdonnalley/v4-types
May 20, 2024
Merged

cristiand391 merged 12 commits into
prerelease/betafrom
mdonnalley/v4-types

Conversation

@mdonnalley

@mdonnalley mdonnalley commented May 7, 2024 •

Copy link
Copy Markdown
Contributor
  "exports": {
    ".": "./lib/index.js",
    "./args": "./lib/args.js",
    "./command": "./lib/command.js",
    "./config": "./lib/config/index.js",
    "./errors": "./lib/errors/index.js",
    "./execute": "./lib/execute.js",
    "./flags": "./lib/flags.js",
    "./flush": "./lib/flush.js",
    "./handle": "./lib/errors/handle.js",
    "./help": "./lib/help/index.js",
    "./hooks": "./lib/interfaces/hooks.js",
    "./interfaces": "./lib/interfaces/index.js",
    "./logger": "./lib/logger.js",
    "./performance": "./lib/performance.js",
    "./run": "./lib/main.js",
    "./settings": "./lib/settings.js",
    "./util/ids": "./lib/util/ids.js",
    "./ux": "./lib/ux/index.js"
  },

@W-15470589@
@W-15470627@

@mdonnalley
mdonnalley marked this pull request as draft May 7, 2024 19:19
Comment thread package.json
],
"license": "MIT",
"main": "./lib/index.js",
"exports": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this includes all the ones I came here to check 😄

Comment thread src/errors/errors/cli.ts

export class CLIError extends Error implements OclifError {
code?: string
code?: string | undefined

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the value of having both ? and the | undefined ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this #960

Comment thread src/config/config.ts
public bin!: string
public binAliases?: string[]
public binPath?: string
public binAliases?: string[] | undefined

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should any of these be readonly? conversely, do we want people mutating them all?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't be readonly because all these props are assigned in the .load method. Typescript doesn't like that

@mdonnalley
mdonnalley marked this pull request as ready for review May 15, 2024 21:06
@cristiand391
cristiand391 merged commit 3f421e7 into prerelease/beta May 20, 2024
@cristiand391
cristiand391 deleted the mdonnalley/v4-types branch May 20, 2024 15:29
mdonnalley added a commit that referenced this pull request Jun 4, 2024
* chore: bump major version

* feat: slimmer ux (#1056)

* chore: bump major version

* feat: slimmer ux module

* test: no fancy-tests

* chore(release): 4.0.0-v4.0 [skip ci]

* chore: code review

* chore(release): 4.0.0-v4.1 [skip ci]

* chore(release): 4.0.0-beta.1 [skip ci]

* chore: remove duplicate dep

* test: windows unit tests

* test: windows unit tests

---------

Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com>

* chore(release): 4.0.0-beta.2 [skip ci]

* feat: add customizable logger

* feat: remove native error logger

* fix: cache child loggers

* chore(release): 4.0.0-beta.3 [skip ci]

* chore(release): 4.0.0-beta.4 [skip ci]

* feat: support rc files (#1067)

* feat: support rc files

* chore: code review

* chore(release): 4.0.0-beta.5 [skip ci]

* chore(release): 4.0.0-beta.6 [skip ci]

* fix: revert ignoreDuplicates in warn

* chore(release): 4.0.0-beta.7 [skip ci]

* feat: improved types and top-level exports (#1076)

* feat: improved PJSON type

* feat: enable exactOptionalPropertyTypes

* feat: theme can be object or file path

* feat: support target and identifier for helpClass

* chore: add jsdocs to Configuration type

* fix: add back scope to pjson type

* feat: top level exports

* fix: simplify ux export

* chore: cleanup

* feat: export logger too

* chore(release): 4.0.0-beta.8 [skip ci]

* feat: remove baseFlags

* test: use oclif/test v4 and improve test coverage

* fix: clarify types

* test: use default sinon sandbox

* test: use new major of oclif/test

* test: add interop test for core v3

* test: skip spinner test on windows

* chore: code review

* chore(release): 4.0.0-beta.9 [skip ci]

* fix: restore baseFlags support (#1085)

* chore(release): 4.0.0-beta.10 [skip ci]

* fix: improve types and ProdOnlyCache

* chore(release): 4.0.0-beta.11 [skip ci]

* fix: update hook type

* chore(release): 4.0.0-beta.12 [skip ci]

* fix: allow empty ux.stdout

* chore(release): 4.0.0-beta.13 [skip ci]

* chore: add ux README

* fix: check supports-color in colorize

* chore(release): 4.0.0-beta.14 [skip ci]

* feat: support tsx for runtime transpilation

* chore(release): 4.0.0-beta.15 [skip ci]

* chore(release): 4.0.0-beta.16 [skip ci]

---------

Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com>
Co-authored-by: Steve Hetzel <shetzel@salesforce.com>
Co-authored-by: Willie Ruemmele <willieruemmele@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants