oss_21_logger_provider_log_record_limits #37

Activity

1. ocelotl commented on Jul 22, 2026

   

   ocelotl

   on Jul 22, 2026

   OwnerAuthor

   More actions

   🔒 Internal (dash0) — not for upstream.

   • Linear: https://linear.app/dash0/issue/OSS-21/l2-loggerprovider-cannot-configure-logrecordlimits-programmatically (finding L2)
   • Slug/branch/worktree: oss_21_logger_provider_log_record_limits
   • Commit: 88b7449a7 · PR: oss_21_logger_provider_log_record_limits #42
   • Validation: opentelemetry-sdk logs suite 115 passed; scope sdk + changelog.
   • Reviewer notes: (1) touches the same file as OSS-22/PR oss_22_logger_enabled #26 (sdk _logs/_internal/__init__.py) — merge sequentially. (2) The configuration-package path that "warns and drops" log limits was intentionally NOT touched (out of scope); it can now consume this hook — this is the programmatic side of the limitation flagged on OSS-26/PR oss_26_declarative_config_env_substitution #36.
2. ocelotl commented on Jul 22, 2026

   

   ocelotl

   on Jul 22, 2026

   OwnerAuthor

   More actions

   📣 Public-facing draft — to be opened upstream in open-telemetry/opentelemetry-python. No internal references; copy verbatim.

   Title: LoggerProvider does not accept programmatic LogRecordLimits (unlike TracerProvider/SpanLimits)

   SpanLimits can be configured programmatically via TracerProvider(span_limits=...). The logs SDK has an equivalent LogRecordLimits type (opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py) and applies it in ReadWriteLogRecord.__post_init__, but LoggerProvider.__init__ has no limits parameter. As a result ReadWriteLogRecord._from_api_log_record never passes a limits value, so emitted log records always use the default LogRecordLimits, and limits can only be influenced via environment variables — there is no programmatic path.

   Spec: specification/logs/sdk.md — "LogRecord Limits" (the SDK must allow configuring attribute count / value-length limits on the LoggerProvider). Java reference: SdkLoggerProviderBuilder.setLogLimits(...) with the LogLimits type.

   Proposed fix

   Add a keyword-only limits: LogRecordLimits | None parameter to LoggerProvider.__init__, store it, pass it to each Logger, and thread it into _from_api_log_record so it is applied when constructing log records. Default (no argument) behavior remains unchanged (falls back to env vars / defaults).