Skip to content

fix strokeCap prop not being passed to foreground arc from /Circle.js#65

Merged
oblador merged 3 commits intooblador:masterfrom
byronhallett:master
Aug 2, 2017
Merged

fix strokeCap prop not being passed to foreground arc from /Circle.js#65
oblador merged 3 commits intooblador:masterfrom
byronhallett:master

Conversation

@byronhallett
Copy link
Contributor

The default prop was being used, and the circle progress bar was always being
rendered with 'butt' type strokeCap

…ponent

The default prop was being used, and the circle progress bar was always being
rendered with 'butt' type strokeCap
@oblador
Copy link
Owner

oblador commented Jul 31, 2017

Thanks for your PR! Looking at the changes there's a bunch of them that seems unrelated to the bug you're describing, can you explain what they do?

@byronhallett
Copy link
Contributor Author

byronhallett commented Jul 31, 2017

Oh no! Those aren't supposed to be there.
Would you like to close this PR and I'll make another one for only this fix?

The other changes are related to having an unclosed circle and don't belong in this PR.
The result is this:
image

@oblador
Copy link
Owner

oblador commented Aug 1, 2017

You can just update this PR and I'll squash it :-)

@byronhallett
Copy link
Contributor Author

Ok, thanks, I've reverted that commit.
Thanks for being patient with me. I'd assumed that the PR wouldn't auto update to include commits post creation.
Good to know :)

@oblador oblador merged commit c1db056 into oblador:master Aug 2, 2017
@oblador
Copy link
Owner

oblador commented Aug 2, 2017

Thanks man!

@oblador
Copy link
Owner

oblador commented Aug 22, 2017

Released in 3.4.0.

@mak12
Copy link

mak12 commented Jun 22, 2022

Oh no! Those aren't supposed to be there. Would you like to close this PR and I'll make another one for only this fix?

The other changes are related to having an unclosed circle and don't belong in this PR. The result is this: image

@byronhallett did you push change for this view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants