Conversation
The conversion read the bytes of its argument and printed `true` only for `01-`, so a text or a number came out as `false`, which says something about them that is not so. It accepts the bytes of `true` and `false` now and terminates on anything else, naming the argument. Two tests recover from that termination, since a returned text of more than one byte fails to dataize as a boolean exactly as a termination does and a `-->` test would pass either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxFBB1HWHS1xgdM6bT9Qvw
|
Contributor
|
These counts changed in this branch,
They are defined in .github/workflows/counts.yml |
|
@yegor256 Thanks for the contribution! You've earned +4 points for this: +16 as a basis; -8 for the lack of code review; -4 for too few (31) hits-of-code. Please, keep them coming. Your running score is +1690; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7985.
%bread the bytes of its argument and printedtrueonly for01-, so everything else came out asfalse:which states something about a string and a number that is not so. It accepts the bytes of
trueandfalsenow and terminates on anything else, naming the argument, the way%sand%drefuse what they cannot convert.Two tests cover it. They recover from the termination rather than declaring it with
-->, for the reason the file's own header already gives about%f: a returned text of more than one byte fails to dataize as a boolean exactly as a termination does, so a-->test would have passed againstmastertoo.recoveredgives the assertion something to compare, and againstmasterit would come back"false"rather than"stopped".The header gains a paragraph on what
%bnow refuses, and on the other face of the same coin the file already documents: a one-character text of U+0000 or U+0001 has the bytes of a boolean and is still accepted.TestEOstringis green (418 tests) on a localmvn clean test -pl :eo-runtime -Deo.deadline=3600, with both new tests among them.Touches the same
ifchain as #7976 (PR #8015), so whichever lands second will want a rebase.