fix: deprecated diagnostic jumping config

[nathanzeng]

opts.jump.float is deprecated as of the 0.12 release. To confirm, use the kickstart config and run:
:checkhealth vim.deprecated

• ⚠️ WARNING opts.jump.float is deprecated. Feature will be removed in Nvim 0.14
  • ADVICE:
    • use opts.jump.on_jump instead.

This also bumps the minimum version to 0.12

[oriori1703]

I checked neovim/neovim@dbe17da, which deprecated the option, and it seems like we should do the following if we want to exactly match the previous behaviour:

Suggested change

	on_jump = function(diagnostic, _)
	if not diagnostic then return end
	vim.diagnostic.open_float { focus = false }
	end,
	on_jump = function(_, bufnr)
	vim.diagnostic.open_float {
	bufnr = bufnr,
	scope = 'cursor',
	focus = false,
	}
	end,

[nathanzeng]

I included if not diagnostic then return end because I saw it in the neovim help :h diagnostic-on-jump-example or see here

I didn't add bufnr or scope because I believe the defaults for those values are the same as what we would pass? Let me know if you want me to add it explicitly though and I'll force push

[oriori1703]

Because this uses a feature (on_jump) that was added in 0.12 you should also bump the version in lua/kickstart/health.lua.

On a related note, should we wait a bit before dropping support for 0.11?
I know a lot of people get Neovim from their distro’s package manager, and most distros haven’t updated to 0.12 yet.

Both Ubuntu and Fedora are releasing new versions this month, and I assume they’ll include 0.12. Should we wait until those releases?

(Mostly thinking out loud - though I would love to hear others' opinion)

[nathanzeng]

Thanks for the review, and good catch on bumping the health check. Waiting for Ubuntu and Fedora seems like a good idea to me.