Skip to content

Critical bugfix for scons clean and base language - #20

Merged
josephsl merged 2 commits into
nvdaaddons:masterfrom
nvda-es:baseLanguage
Jan 3, 2021
Merged

josephsl merged 2 commits into
nvdaaddons:masterfrom
nvda-es:baseLanguage

Conversation

@jmdaweb

@jmdaweb jmdaweb commented Jan 3, 2021

Copy link
Copy Markdown
Contributor

This is a follow-up for a previous pull request where baseLanguage variable was added. It fixes a bug which caused scons to remove always the english documentation regardless of the base language when scons clean command was used. Now, the directory with the base language documentation is removed instead.

…stead of removing documentation for the chosen base language, english documentation was removed
@josephsl

josephsl commented Jan 3, 2021

Copy link
Copy Markdown
Contributor

Thanks, part of Add-on Template 2020.4.

@josephsl
josephsl merged commit d70c64a into nvdaaddons:master Jan 3, 2021
CyrilleB79 pushed a commit to CyrilleB79/AddonTemplate that referenced this pull request Mar 3, 2026
@nvdaes nvdaes mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants