Repository navigation
Conversation
…compatibility of the sconstruct file with Python 2.7 Thus, the scons command will be able to build the add-on with both Python 2.7 and 3.x.
Contributor
Author
|
I will wait for the merger of the PR of @nvdaes before proposing this one |
Contributor
|
Hi, for all practical purposes, Python 2.7 is no more. Thus I propose setting a “sunset date” so folks can transition to using Python 3 version of sCons to align which Python version to use for development. Thanks.
From: abdel792 <notifications@github.com>
Sent: Friday, January 3, 2020 10:27 AM
To: nvdaaddons/AddonTemplate <AddonTemplate@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvdaaddons/AddonTemplate] In addition to the HTML5 support proposed by @nvdaes, added backward compatibility of the sconstruct file with Python 2.7 (#12)
I will wait for the merger of the PR of @nvdaes <https://github.com/nvdaes> before proposing this one
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AB4AXECCWETGTRXQ2CKOW2DQ357PTA5CNFSM4KCQJVWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIBYN2Y#issuecomment-570656491> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEARFIKZQRJ7JH2Q4J3Q357PTANCNFSM4KCQJVWA> .
|
Contributor
Author
|
Thanks Joseph, I will take your advice into consideration. Finally, I don't think to redo this PR because Python 2.7 is no more. Thanks again and have a good week-end. |
nvdaes
pushed a commit
to nvdaes/AddonTemplate
that referenced
this pull request
Mar 3, 2026
…tifact from 5 to 6 (nvdaaddons#12)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed by this Pull Request:
In addition to the HTML5 support proposed by @nvdaes, addition of backward compatibility of the sconstruct file with Python 2.7
Thus, the scons command will be able to build the add-on with both Python 2.7 and 3.x.