Skip to content

Remove the generation of the Json #36

Closed

Description

@CyrilleB79

When building the add-on, a Json file is generated.

It was useful when the add-on store submission process required it. But now, the submission process only requires to open an issue with an URL pointing to the .nvda-addon file and the generation of the Json is done transparently by the store submission process.

I recommend to remove the generation of the Json from the scons default target. It's up to you if you want to generate the whole code for Json generation or if you want to keep it. But if you keep it, please add a separate target to generate only the .json file, e.g. "scons json"

It's also worth noting that the json is not deleted when running "scons -c".

Activity

  1. josephsl commented on Oct 21, 2023

    @josephsl
    Contributor

    Hi,

    For now json generator will be commented out, with an option for creating a separate scons target for it in the future.

    Thanks.

  2. CyrilleB79 commented on Oct 21, 2023

    @CyrilleB79
    ContributorAuthor

    Thanks. That's what I did for my own add-ons.

  3. added a commit that references this issue on Oct 4, 2024
    bda5b59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions