Skip to content

fix(Checkbox/RadioGroup): use border-default on card and table variants - #6884

Merged
benjamincanac merged 1 commit into
v4from
fix/checkbox-card-border-default
Aug 26, 2026
Merged

benjamincanac merged 1 commit into
v4from
fix/checkbox-card-border-default

Conversation

@benjamincanac

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

#6726 added a hover border to the card and table variants of Checkbox, CheckboxGroup and RadioGroup but left the resting border on border-muted. In dark mode border-muted and border-accented resolve to the same value, so the hover does nothing there:

token light dark
border-default neutral-200 neutral-800
border-muted neutral-200 neutral-700
border-accented neutral-300 neutral-700

In light mode it only works by accident, since border-muted happens to equal border-default there.

This switches the resting border to border-default, so the card sits at neutral-800 in dark and the existing hover:...:border-accented actually reads. It also lines these up with every other card-like surface in the library (prose/card, content-surround, pricing-table, file-upload). No visual change in light mode.

The remaining border-muted uses in src/theme are prose and editor code surfaces paired with bg-muted, which is the intended pairing and stays as is.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 57ca902c-a48a-4925-98e3-1d54a7dc33ca

📥 Commits

Reviewing files that changed from the base of the PR and between b751eae and 4d5e1da.

⛔ Files ignored due to path filters (6)
  • test/components/__snapshots__/Checkbox-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/Checkbox.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/CheckboxGroup-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/CheckboxGroup.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/RadioGroup-vue.spec.ts.snap is excluded by !**/*.snap
  • test/components/__snapshots__/RadioGroup.spec.ts.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • src/theme/checkbox-group.ts
  • src/theme/checkbox.ts
  • src/theme/radio-group.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change replaces border-muted with border-default in checkbox-group table items, checkbox card roots, and radio-group card and table items. Existing hover styling, rounded-card styling, and optional color-transition classes remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4d5e1

The change corrects resting border colors for Checkbox and RadioGroup card and table variants, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the affected Checkbox and RadioGroup variants and the change from border-muted to border-default.
Description check ✅ Passed The description directly explains the dark-mode border issue, the affected components, the intended fix, and the unchanged light-mode behavior.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/checkbox-card-border-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Aug 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing fix/checkbox-card-border-default (4d5e1da) with v4 (b751eae)

Open in CodSpeed

@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@6884

commit: 4d5e1da

@benjamincanac benjamincanac changed the title fix(theme): use border-default on Checkbox/RadioGroup card and table variants fix(Checkbox/RadioGroup): use border-default on card and table variants Aug 26, 2026
@benjamincanac
benjamincanac merged commit 9bdb89b into v4 Aug 26, 2026
27 checks passed
@benjamincanac
benjamincanac deleted the fix/checkbox-card-border-default branch August 26, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant