fix(Checkbox/RadioGroup): use border-default on card and table variants - #6884
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change replaces Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change corrects resting border colors for Checkbox and RadioGroup card and table variants, with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
border-default on Checkbox/RadioGroup card and table variantsborder-default on card and table variants
🔗 Linked issue
❓ Type of change
📚 Description
#6726 added a hover border to the
cardandtablevariants ofCheckbox,CheckboxGroupandRadioGroupbut left the resting border onborder-muted. In dark modeborder-mutedandborder-accentedresolve to the same value, so the hover does nothing there:border-defaultneutral-200neutral-800border-mutedneutral-200neutral-700border-accentedneutral-300neutral-700In light mode it only works by accident, since
border-mutedhappens to equalborder-defaultthere.This switches the resting border to
border-default, so the card sits atneutral-800in dark and the existinghover:...:border-accentedactually reads. It also lines these up with every other card-like surface in the library (prose/card,content-surround,pricing-table,file-upload). No visual change in light mode.The remaining
border-muteduses insrc/themeare prose and editor code surfaces paired withbg-muted, which is the intended pairing and stays as is.📝 Checklist